-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(esdoc): add playground environment in ESDoc-generated page #1385
Conversation
I was thinking about adopt in-frame jsbin like http://xgrommx.github.io/rx-book/content/observable/observable_instance_methods/amb.html in further - would it be considerable? doesn't require to open up console, also supports different env (TypeScript, mostly) |
We can have both. Many libraries anyway have the library available in devtools console, so we should do that too for consistency. About the JSBin, if we do that, we shouldn't do it for each operator, because the page will definitely get heavy with so many iframes. |
: Yes, totally agree.
: Yes, totally agree (too). I liked idea of embedding jsbin but also not quite much in favor of having it per each operator. |
b056479
to
6d337c6
Compare
Looks good to me. |
This looks good. Especially as a first pass. The only thing I can think of is some people might create a Subscription (similar to what's been suggested in console) and not keep a handle to their subscription so they can tear it down. But it's a fine solution until we can get something more robust. Also I <3 ASCII Art. |
Just needs a rebase it looks like. |
I'll rebase it tomorrow, and I can also change that suggested example to have |
6d337c6
to
a76fb91
Compare
Rebested. |
Add Rx.umd.js script to the ESDoc-generated page, so RxJS can be experimented in the DevTools. Also add a welcome message in the console, and a hint text in index.md.
a76fb91
to
98e183d
Compare
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Add Rx.umd.js script to the ESDoc-generated page, so RxJS can be experimented in the DevTools. Also add a welcome message in the console, and a hint text in index.md.
To see this page live, open http://rxjs5-esdoc-rxjs-playground.surge.sh/