-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(decision-tree-widget): implement Operator Decision Tree widget #1406
Conversation
That is super cool. |
Love this too. 💘 |
It seems the operator's url is not correct, such as |
@todoubaba The links are correct, but they refer to a future version of the Observable.html page, we're depending on PR #1376 merged first. |
Yeah, looking forward that 👍 |
❤️ Change looks good to me. |
I need to rebase, apparently |
8baa820
to
e74c9a0
Compare
Rebased, but it will conflict with #1385 when that is merged. (and will need another rebase) |
e74c9a0
to
10142d0
Compare
Rebossed. |
"dependencies": { | ||
"@motorcycle/core": "^1.1.0", | ||
"@motorcycle/dom": "^1.2.1", | ||
"most": "^0.18.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL... what?! 👎
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're just asking for @briancavalier to come tease me aren't you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 👍 🚢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is so good, it's nearly up there with when that gentleman asked @Blesh on his article, if he'd used RxJS!!
#acidental-trolling
So, you know what I'm going to say. This is really cool. We should probably implement it with RxJS 5 and annotate the code. :P LOLOLOL... Too funny, @staltz |
So, in reality it's not trolling and it's absolutely serious stuff. Cycle.js doesn't currently work with RxJS v5, we're working on getting that support up. In the meanwhile, RxJS v4 is quite huge in size to include to this page, specially because we already have full RxJS v5 loaded in the page. So I went for something small in size, and I chose a version of Cycle.js called Motorcycle.js, focused on performance. If you'd prefer for PR purposes that I just use RxJS v4 even if it's larger, fine by me. Or, I can place the whole decision tree widget elsewhere, make it generic for any purposes, then just import it here. So, your call. |
Honestly, that's probably better. But ideally, we'd have it in RxJS 5 and it would be annotated. Could write it in Angular 2 ;) haha. |
Could write it in anything. I just wanted to get it done.
Will do when the support is out. I'll update this PR with Rx4 to make y'all happy. |
@staltz Now you can use only what you want of Rx instead of whole library https://github.com/Reactive-Extensions/RxJS/tree/master/src/modular |
10142d0
to
97d307a
Compare
I updated the PR to use Rx v4, and uglifyjs. |
97d307a
to
71e7eb5
Compare
Rebased |
Looks good to me (but another rebase... 😓 ) |
71e7eb5
to
59d72be
Compare
Rebombed. :) |
59d72be
to
3181ccd
Compare
@Blesh are you serious about this PR having to use RxJS v5 for dogfooding purposes? Just want to know what are your intentions because I could honestly convert this to a pseudo-Cycle.js app, since it's so small I can give up a bit on the actual framework and just apply the same architectural ideas. |
3181ccd
to
6486b33
Compare
Ok, I just did what I said in my previous comment, so now it should be fully Blesh-Compliant Enterprise Software. |
25daca6
to
f4de0d6
Compare
f4de0d6
to
fdffad2
Compare
Rebased ✅ |
I think change's ok to be checked in, will check this in around tomorrow unless other suggestion's around. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Implements the Operator Decision Tree widget, and add to both doc/index.md and doc/operators.md
Notice specially
doc/decision-tree-widget/tree.yml
which is the decision tree data encoded in YAML. Probably the decision tree YAML file still needs review and improvement, but we could update it separately from this PR.To see this page live, open http://rxjs5-esdoc-decision-tree.surge.sh/