Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dist): Adds a minified license to minified files #1455

Closed
wants to merge 1 commit into from

Conversation

niksrc
Copy link
Contributor

@niksrc niksrc commented Mar 11, 2016

Description:
This adds a minimal license to minified files to reduce file size. #1290
Related issue (if exists):

@kwonoj
Copy link
Member

kwonoj commented Mar 11, 2016

Change looks good to me, not 100% sure minified license would be sufficient to state Apache 2 only. Once @Blesh confirms it's ok, let me check this in right away.

@niksrc
Copy link
Contributor Author

niksrc commented Mar 12, 2016

@kwonoj Actually it states apache 2 only with URL of license. I mistakenly added 'minified' to the commit msg.

@kwonoj
Copy link
Member

kwonoj commented Mar 12, 2016

Yes, aware of that. I've used terms 'minified' just state it's been shortened.

@benlesh
Copy link
Member

benlesh commented Mar 14, 2016

This should work.

@kwonoj
Copy link
Member

kwonoj commented Mar 17, 2016

I'll check this in around today.

@kwonoj
Copy link
Member

kwonoj commented Mar 18, 2016

Merged with 8a8d0f0, appreciate for effort @niksrc ! (fyi: I've amended commit message to not start with capitalized to follow commit message guideline, hope this is ok for you)

@niksrc
Copy link
Contributor Author

niksrc commented Mar 18, 2016

It's totally cool, sorry i somehow missed that, thanks 😄

@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants