Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(skipUntil): update skipUntil behavior with error, completion #524

Closed
wants to merge 1 commit into from
Closed

fix(skipUntil): update skipUntil behavior with error, completion #524

wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 14, 2015

  • update skipUntil operator behavior
  • add test coverage

closes #518

Updated behavior of operator and migrated RxJS4 test cases with additional expansion.

@kwonoj
fix(skipUntil): update skipUntil behavior with error, completion
0a34ddc 
- update skipUntil operator behavior
- add test coverage

closes ReactiveX#518
@staltz
Copy link
Member

staltz commented Oct 14, 2015

Looks really good

@benlesh
Copy link
Member

benlesh commented Oct 14, 2015

Merged with 6f0d98f. Thanks, @kwonoj!

@benlesh benlesh closed this Oct 14, 2015
@kwonoj kwonoj deleted the fix-skipuntil branch October 14, 2015 20:09
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

skipUntil() operator behavior
3 participants
@kwonoj @staltz @benlesh