Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes mergeAll micro perf tests. #536

Closed
wants to merge 1 commit into from

Conversation

trxcllnt
Copy link
Member

Sadly, the ~6000% speed up was erroneous :(

Actual numbers:

                                         |                     RxJS 4.0.6 |             RxJS 5.0.0-alpha.4 |          factor |      % improved
---------------------------------------------------------------------------------------------------------------------------------------------------
                    mergeall - immediate |                 1,543 (±0.86%) |                13,700 (±0.99%) |           8.88x |          788.2%
                                mergeall |                 1,437 (±0.82%) |                 6,581 (±1.20%) |           4.58x |          358.0%

@trxcllnt
Copy link
Member Author

@Blesh I committed this last night before bed, sorry for the original commit message. I've push -f'd a new message in the correct format.

@benlesh
Copy link
Member

benlesh commented Oct 15, 2015

ROFL... that looks more reasonable.

@benlesh
Copy link
Member

benlesh commented Oct 15, 2015

... and I'll still take ~9x faster.

@benlesh
Copy link
Member

benlesh commented Oct 15, 2015

Merged with: 616e86e

@benlesh
Copy link
Member

benlesh commented Oct 15, 2015

also this makes my graphs more readable. haha.

@benlesh benlesh closed this Oct 15, 2015
@trxcllnt trxcllnt deleted the fix-mergeall-micro-perf branch December 30, 2015 01:52
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants