Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(test): update global hint #580

Closed
wants to merge 1 commit into from

Conversation

kwonoj
Copy link
Member

@kwonoj kwonoj commented Oct 22, 2015

Cosmetic update for test cases for editors supports jshint, hinting like below now resolved.

image

@staltz
Copy link
Member

staltz commented Oct 22, 2015

👍 I don't know why my editor didn't show those warnings.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 22, 2015

Think this is editor-specific, but thought still good to have. :)

@benlesh
Copy link
Member

benlesh commented Oct 26, 2015

This one actually needs to be rebased before I can merge it.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 26, 2015

I will update PR with rebase.

@kwonoj
Copy link
Member Author

kwonoj commented Oct 26, 2015

PR is now rebased with TOT.

@benlesh
Copy link
Member

benlesh commented Oct 27, 2015

merged with 40e9757... thanks @kwonoj

@benlesh benlesh closed this Oct 27, 2015
@kwonoj kwonoj deleted the test-cosmetic branch October 27, 2015 16:49
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants