Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(0.4.x) Can't remove a listener from a MetricEventsPubliser #427

Closed
mikeweisskopf opened this issue Sep 29, 2015 · 1 comment
Closed

(0.4.x) Can't remove a listener from a MetricEventsPubliser #427

mikeweisskopf opened this issue Sep 29, 2015 · 1 comment
Labels
Milestone

Comments

@mikeweisskopf
Copy link

Problem description:

At one point Nitesh mentioned adding removeListener() to MetricEventsPublisher here, but later changed to use Subscription instead. The rational was "returned Subscription can be unsubscribed to remove the listener". However, it seems to me thats not what actually happens.....instead calling unsubscribe only changes the state of the subscription (for example BooleanSubscription.isUnsubscribed() will return true). However, the listener (MetricsEventsPublisher) remains unchanged.

Additional info from Nitesh

Nitesh pointed out the source of the bug here

@NiteshKant
Copy link
Member

Fixed via #428

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants