Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation of doOnUnsubscribe( ) #233

Open
DavidMGross opened this issue Apr 22, 2016 · 1 comment
Open

Improve documentation of doOnUnsubscribe( ) #233

DavidMGross opened this issue Apr 22, 2016 · 1 comment

Comments

@DavidMGross
Copy link
Collaborator

Clarify whether doOnUnsubscribe( ) calls its action when it unsubscribes from the source Observable, not when its subscribers unsubscribe from it's resultant Observable; or whether it calls its action whenever observers to its resultant Observable unsubscribe from it... there's some confusion on the point. The marble diagram may need to be made more evocative of this as well.

See: ReactiveX/RxJava#3877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant