Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interactive (RxMarbles) diagrams don't render in Safari #88

Closed
DavidMGross opened this issue Feb 8, 2015 · 4 comments
Closed

Interactive (RxMarbles) diagrams don't render in Safari #88

DavidMGross opened this issue Feb 8, 2015 · 4 comments
Assignees

Comments

@DavidMGross
Copy link
Collaborator

I tested the new embedded RxMarbles diagrams in Chrome, Firefox, and Safari 7.1.3, and while they seem to work in the first two, they don't render at all in Safari.

When I view-source, the RxMarbles line is <rx-marbles key="foo"></rx-marbles>... that is, unchanged from the static source.

There's a javascript error that only seems to show up in Safari ("TypeError: Attempted to assign to readonly property." at patches-mdv.js, line 57)... not sure if that would have anything to do with it (that error also turns up on pages that don't have embedded RxMarbles diagrams). I don't see any other javascript errors or warnings.

@staltz
Copy link
Member

staltz commented Feb 8, 2015

Sigh I tested in Chrome, Firefox, Opera, and IE, and somehow forgot about the existence of Safari. I'll look into it.

@staltz
Copy link
Member

staltz commented Feb 10, 2015

So it was actually not my new code that was breaking RxMarbles on Safari, that TypeError was already happening before RxMarbles was inserted. That was because of Polymer as a dependency is breaking in Safari. I just removed Polymer in PR #89 , and this error is a known issue to be fixed in Safari, not in Polymer: http://stackoverflow.com/questions/24432798/polymer-project-objects-not-rendering-in-os-x-10-10 . I'm not sure where Polymer is used on the site, if it is used, then you can figure out how to include it, and probably not including in every page (_layouts/default).

RxMarbles working fine in Safari

@DavidMGross
Copy link
Collaborator Author

Looks good to me.

@DavidMGross
Copy link
Collaborator Author

And... we're live: http://reactivex.io/documentation/operators/combinelatest.html

Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants