Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rxjs-tslint breaks tslint #44

Closed
NagRock opened this issue Jun 15, 2018 · 4 comments
Closed

rxjs-tslint breaks tslint #44

NagRock opened this issue Jun 15, 2018 · 4 comments

Comments

@NagRock
Copy link
Contributor

NagRock commented Jun 15, 2018

When I install rxjs-tslint with yarn every thing works fine. But when I remove node_modules and use again yarn to install all dependencies I get many errors like this one:

TypeError: Cannot read property 'length' of undefined
    at cb (C:\workspaces\angular-components\node_modules\tslint\lib\rules\noDuplicateVariableRule.js:79:66)
    at visitNodes (C:\workspaces\angular-components\node_modules\typescript\lib\typescript.js:13272:30)
    at Object.forEachChild (C:\workspaces\angular-components\node_modules\typescript\lib\typescript.js:13479:24)
    at NoDuplicateVariableWalker.walk (C:\workspaces\angular-components\node_modules\tslint\lib\rules\noDuplicateVariableRule.js:86:19)
    at Rule.AbstractRule.applyWithWalker (C:\workspaces\angular-components\node_modules\tslint\lib\language\rule\abstractRule.js:31:16)
    at Rule.apply (C:\workspaces\angular-components\node_modules\tslint\lib\rules\noDuplicateVariableRule.js:34:21)
    at Linter.applyRule (C:\workspaces\angular-components\node_modules\tslint\lib\linter.js:197:29)
    at C:\workspaces\angular-components\node_modules\tslint\lib\linter.js:139:85
    at Object.flatMap (C:\workspaces\angular-components\node_modules\tslint\lib\utils.js:151:29)
    at Linter.getAllFailures (C:\workspaces\angular-components\node_modules\tslint\lib\linter.js:139:32)

I don't need to add any rule to tslint.json, just add rxjs-tslint as dependency and install all dependencies depending on yarn.lock file.

Don't know if this is related to: palantir/tslint#3711 (comment)

@PsychicCat
Copy link

Seems to me that tslint 5.10 is causing the error.

@NagRock
Copy link
Contributor Author

NagRock commented Jun 18, 2018

@PsychicCat I've created PR that should fix this issue. But need to wait to be merged. #45

@mgechev mgechev closed this as completed Jun 22, 2018
@mgechev
Copy link
Collaborator

mgechev commented Jun 22, 2018

Published under 0.1.5.

@NagRock
Copy link
Contributor Author

NagRock commented Jun 22, 2018

@mgechev thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants