Remove the rest of parts which use tryCatch

[tetsuharuohzeki]

This is the list of them which we may be able to remove using tryCatch from:

• BoundCallbackObservable
• BoundNodeCallbackObservable
• AjaxObservable
• WebSocketSubject
• DeferObservable (chore(DeferObservable): add benchmarks & minor perf #1393, by fix(deferObservable): accepts factory returns promise #1484)
• FromEventObservable
• FromEventPatternObservable (refactor(FromEventPatternObservable): remove to use tryCatch #1397)
• IteratorObservable
• bufferToggle
• bufferWhen
• distinctUntilChanged
• expand
• inspect
• mergeScan
• retryWhen
• windowToggle
• windowWhen
• forEach (by fix(forEach): ensure that teardown logic is called when nextHandler t… #1434)
• Subscription (refactor(Subscription): remove to use tryCatch #1389)

[benlesh]

@saneyuki ... I'd like to hold off on these sorts of changes for the time being. We can make these non-breaking changes even after we've pushed out the production release. Right now, I'd like to focus everyone's effort on more critical, possibly breaking changes to RxJS before the 5.0.0 production release.

As such, I'm going to close this issue for now. We can revisit it as time allows. It's definitely something that is on my mind.

Of course, I'll never turn away a PR to improve the performance of the library, and everyone's time here is voluntary. So feel free to work on whatever makes you happy. I just need to prioritize PRs that are more critical to the production release.

[benlesh]

Also, FWIW: There is some talk about possibly creating a more unified strategy for this that is still efficient. Something that we can use a Babel transform here at Netflix to remove the try/catching entirely for a Node/Panic-mode type build for Node.js server use. That means work around this might change again.

[tetsuharuohzeki]

@Blesh Okay. Rather, it was peace of mind that did not become a release blocker.

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.