-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
distinctUntilChanged operator not working #2980
Comments
There are several critical issues in 5.5.0: |
Alright, so downgrade for the time being? |
I would say yes. We did not upgrade to 5.5.0, unfortunately everywhere is "range cavet" version (in our case we had ^5.4.3 so it has been automatically updated to 5.5.0). Change to pinned version 5.4.3 fixed all problems. |
@kwonoj well.. it is not so easy to detect which is involved in our errors - i cannot simulate the problem in pure rxjs, i tried today. :-/ Is it possible to try reproduce steps here: i dont want you to debug my application, just to start one run, maybe rxjs 5.5.0 is in conflift with zone.js ? |
I can't guess, or debug into code you've posted in issue you shared. Except module loading ergonomics, operator side 5.5 has not changed especially specific operator in this issue, also isolated code works fine reason I think this is application side issue instead of library side issue. I'll keep opening issue, but can't say I can dig this with current state. |
@kwonoj ok, unfortunately i am not able to debug it, i think it needs strong knowledge of how Angular (maybe zone.js breaks rxjs)+angular-cli work (atleast in my case, i cannot tell everyone else is using any framework), so i can only wait for response from angular team. I have just hoped you would be able to detect the issue, because there are only rxjs calls in callstack.. However i know it very difficult, because everything can change (monkeypatch) anything and conflict anything... :-( |
Found the issue, there was an additional subscription in my code that I had forgotten about, sorry to bother you. |
That took waaaay to long to figure out. |
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
RxJS version: 5.5.0
Code to reproduce:
Expected behavior:
The code should only print once.
Actual behavior:
It prints twice.
Additional information:
I haven't been able to test that example code specifically for this issue, its occuring in a angular component in this code:
And I've check before and after the
distincUntilChanged
the value in the pipe, and I am absolutely certain that there are no values being passed between the two identical strings. If anyone has a good plunker template for rxjs I could make a plunker (I dont have time rn to do it myself)The text was updated successfully, but these errors were encountered: