Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include changelog history for each operator on their doc page #4593

Open
1 of 5 tasks
martinsik opened this issue Feb 25, 2019 · 5 comments
Open
1 of 5 tasks

Include changelog history for each operator on their doc page #4593

martinsik opened this issue Feb 25, 2019 · 5 comments
Labels
docs Issues and PRs related to documentation

Comments

@martinsik
Copy link
Contributor

Please check those that apply

  • typo
  • documentation doesn't exist
  • documentation needs clarification
  • error(s) in example
  • needs example

Description Of The Issue

I personally find it increasingly difficult to keep track of what operator behavior has changed in what version and I always have to search through CHANGELOG.md.

So it made me thinking that the API documentation for each operator could include a section with all changes ordered by RxJS version (ideally with links to relevant issues and PRs). CHANGELOG.md already has each line starting with scope so this could work automatically by "just" creating another dgeni processor.

@imcotton
Copy link
Contributor

imcotton commented Mar 1, 2019

This would be great, reminds me what Node.js been doing, e.g. fs.readFile (click the History toggle)

@martinsik
Copy link
Contributor Author

@imcotton That's exactly what I meant.

@niklas-wortmann
Copy link
Member

Oh that is a very cool idea. I will think about it and add some of my thoughts later on!

@niklas-wortmann niklas-wortmann added the docs Issues and PRs related to documentation label Mar 7, 2019
@martinsik
Copy link
Contributor Author

Maybe related to this #5128

@BioPhoton
Copy link
Contributor

Hi @martinsik!

@ deprecations can be important from 2 perspectives:

  • A) I used an operator back then and now it is not working how I used it. I want to have a history of changes for the operator in question
  • B) I want to upgrade RxJS and get a complete list of changes from my current to the version in question

I suggest a simple data view change in the MigrationTimeline.

You can switch from group by version to group by subject .e.g. operators.

This would

  • help A)
  • help B)
  • don't bloat the documentation page even more. (Actual the deprecated overloads make it noisy)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Issues and PRs related to documentation
Projects
None yet
Development

No branches or pull requests

4 participants