Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exhaustAll marble diagram references deprecated exhaust function #6909

Closed
mlegenhausen opened this issue Mar 25, 2022 · 3 comments · Fixed by #6983
Closed

exhaustAll marble diagram references deprecated exhaust function #6909

mlegenhausen opened this issue Mar 25, 2022 · 3 comments · Fixed by #6983
Assignees

Comments

@mlegenhausen
Copy link

Describe the bug

The marble diagram in the description references the deprecated "exhaust" function.

Expected behavior

The text "exhaust" needs be changed to "exhaustAll" in the exhaust.png and resulting from that the file should be renamed to exhaustAll.png.

Reproduction code

No response

Reproduction URL

https://rxjs.dev/api/operators/exhaustAll

Version

7.5.5

Environment

No response

Additional context

No response

@jakovljevic-mladen jakovljevic-mladen self-assigned this Mar 26, 2022
@jakovljevic-mladen
Copy link
Member

@timdp, I will need some help from you with this one. The current marble diagram for exhaustAll operator looks like this:

image

I need to create the second "inner" Observable with opacity applied. Is it possible with Swirly package to apply opacity to a single inner Observable and if it is, can you give me an example how to do it? Of course, if you have time to open a PR instead, feel free to do it.

@timdp
Copy link
Contributor

timdp commented May 30, 2022

I think you should be able to change the stroke and individual fill colors. Lowering the opacity doesn't seem like the best idea since it might reveal overlapping strokes. HSL color notation should help though.

That said, it's probably going to be tedious to do it by hand. You'll probably want to use the JS API and automate the color computations. I'll also give some thought to making it easier through styling.

@timdp
Copy link
Contributor

timdp commented May 31, 2022

I've added experimental support for this in v0.18.1-alpha.0.

It works by adding a new ghosts parameter, because that's what appeared to be the internal name in the TestScheduler code. Please give it a try and let me know what you think.

To get you started, here's a (nonsensical) example:

x = ---a---b--|

y = ----c-----d-|

z = ---e-#

--x----y----z--------|
ghosts = y

> mirror

--x----y----z--------|
ghosts = x, z

diagram

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants