Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Use setup-node action to cache dependencies #7134

Merged
merged 1 commit into from Jan 24, 2023
Merged

chore: Use setup-node action to cache dependencies #7134

merged 1 commit into from Jan 24, 2023

Conversation

jongwooo
Copy link
Contributor

Signed-off-by: jongwooo jongwooo.han@gmail.com

Description

Updated workflows to cache dependencies using actions/setup-node. setup-node@v3 or newer has caching built-in.

AS-IS

- uses: actions/setup-node@v1
  with:
    node-version: ${{ matrix.node }}

TO-BE

- uses: actions/setup-node@v3
  with:
    node-version: ${{ matrix.node }}
    cache: npm

It’s literally a one line change to pass the cache: npm input parameter.

References

Signed-off-by: jongwooo <jongwooo.han@gmail.com>
@benlesh benlesh merged commit db57d69 into ReactiveX:master Jan 24, 2023
@benlesh
Copy link
Member

benlesh commented Jan 24, 2023

Thank you, @jongwooo . I wouldn't have known about this. I'm focused on other things. :)

@jongwooo jongwooo deleted the chore/use-setup-node-action-to-cache-dependencies branch January 24, 2023 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants