Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Errors with SymbolShim in some browsers #999

Closed
benlesh opened this issue Dec 8, 2015 · 2 comments · Fixed by #1000
Closed

Errors with SymbolShim in some browsers #999

benlesh opened this issue Dec 8, 2015 · 2 comments · Fixed by #1000
Assignees
@benlesh
Labels
bug Confirmed bug

Comments

@benlesh
Copy link
Member

benlesh commented Dec 8, 2015

According the the Angular core Slack, there is an issue in some browsers when trying to call Symbol.for. Namely in Safari 8 and all versions of IE.

I haven't reproduced this yet, but I can see/understand where the issue is. Such is the danger with DIY polyfills.

You can see that Symbol is supported in more browsers than Symbol.for is.
@benlesh benlesh added the bug Confirmed bug label Dec 8, 2015
@benlesh benlesh self-assigned this Dec 8, 2015
@benlesh benlesh mentioned this issue Dec 8, 2015
Merged
@luisgabriel
Copy link
Contributor

It seems to be the same problem as #988.

@benlesh benlesh mentioned this issue Dec 8, 2015
Closed
@lock
Copy link

lock bot commented Jun 7, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock bot locked as resolved and limited conversation to collaborators Jun 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@benlesh benlesh

Labels
bug Confirmed bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(SymbolShim): ensure for function even if Symbol already exists
2 participants
@luisgabriel @benlesh