Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why reset size on resize? #4

Open
Florian-Schoenherr opened this issue Sep 16, 2021 · 3 comments
Open

Why reset size on resize? #4

Florian-Schoenherr opened this issue Sep 16, 2021 · 3 comments

Comments

@Florian-Schoenherr
Copy link

Florian-Schoenherr commented Sep 16, 2021


This resets the sizing of every Pane if you resize the window, I think this might have been an oversight, or is there too much logic involved for you to support it?

@Readiz
Copy link
Owner

Readiz commented Sep 20, 2021

This happens in very limited situations.
For example,

  1. When you press "F12" key while you drag splitter.
  2. When you maximize your window(ex: Windows Key + Up) while you drag splitter.

I got several issues like upper ones, and resetSize() will resolve these.

@Florian-Schoenherr
Copy link
Author

I'm building something with electron, so there will be window resizing involved.
It's a substantial fault. What happens if we just leave away the reset?

@Readiz
Copy link
Owner

Readiz commented Sep 21, 2021

I also made this project for electron, so maybe you'll have the same issue I got.
If you delete "reset" thing, sometimes the splitter has abnormal size, or loses the control to handle.
If you have other solution rather then "reset", any contribution will be welcomed. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants