Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rank should not be required for Prospect on New Person #712

Open
VanAuken opened this issue Jun 14, 2018 · 5 comments
Open

Rank should not be required for Prospect on New Person #712

VanAuken opened this issue Jun 14, 2018 · 5 comments

Comments

@VanAuken
Copy link
Collaborator

When making a New Person, people are often entered as Prospect or Applicant. Rank is required in order to save, and currently we are using 'unknown' to meet requirements.

Accurate logic would not require a rank for 'prospect' or 'applicant'. A rank is only needed for people who have joined. This would also require a blank or null choice for rank.

@yasirazgar
Copy link
Contributor

I can look into this.

@houhoulis
Copy link
Collaborator

@VanAuken ,

Considering a person might have a Status such as "Applicant", I approve of removing the requirement that a "Rank" (title) be entered for them. However, I'm not certain, but this issue might be requesting to require a "Rank" for certain statuses but not others. I'm not in favor of hard-coding that level of logic into the app; could we just make "Rank" optional for all people?

I'm not in favor of hard-coding 'Rank required for Statuses X, Y, and Z' logic because I'm not sure that all organizations will have the same idea about which Statuses should require a Rank. Until we have more configurability built into the app, I'd rather avoid such detailed restrictions.

Can we make "Rank" optional for all people?

@kgf
Copy link
Member

kgf commented Oct 27, 2018

I agree with Chris, both about not trying to hard code a matrix, and not requiring title/rank for anyone at this time.

@karmenlu
Copy link

karmenlu commented Oct 27, 2019

I would like to work on/claim this issue. @kgf

@kgf kgf added the Claimed label Oct 28, 2019
@kgf
Copy link
Member

kgf commented Oct 28, 2019

Thanks, @klu17

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants