Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timecard sorting by date is broken on Profile page #749

Open
masukomi opened this issue Mar 22, 2019 · 1 comment
Open

Timecard sorting by date is broken on Profile page #749

masukomi opened this issue Mar 22, 2019 · 1 comment

Comments

@masukomi
Copy link
Collaborator

masukomi commented Mar 22, 2019

Reproduction

  • Find or create a user with multiple timecards spanning multiple years
  • go to their profile
  • expand the time card section

First Problem

Timecards appear to be sorted oldest first. This is the least useful sorting. They should be newest to oldest.

Second Problem

Clicking on the sorting icon by end date doesn't seem to actually work. Timecards should be sorted by end date, and then when you click it again they should be resorted by end date in the opposite order.

@kgf
Copy link
Member

kgf commented Oct 31, 2019

I was not able to reproduce the second problem. Note that timecards without a start time or end time will sort oddly.
On the first problem, the table seems to be sorted by the person's name on load. This table is a partial that is shared by the event show page as well. We would need to create a new partial to correct this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants