Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release to Brew #26

Closed
ReagentX opened this issue Oct 19, 2022 · 4 comments
Closed

Release to Brew #26

ReagentX opened this issue Oct 19, 2022 · 4 comments
Labels
wontfix This will not be worked on

Comments

@ReagentX
Copy link
Owner

ReagentX commented Oct 19, 2022

imessage-exporter.rb:

class ImessageExporter < Formula
  desc "Export MacOS iMessage data + run iMessage Diagnostics"
  homepage "https://github.com/ReagentX/imessage-exporter"
  url "https://github.com/ReagentX/imessage-exporter/archive/refs/tags/0.1.9.tar.gz"
  sha256 "033789e51e3621a74b19e4a5339f0e0b65c2d33b8c3e367a5f7fbd1cdfa642e7"
  license "GPL-3.0-or-later"

  depends_on "rust" => :build

  def install
    system "cargo", "install", *std_cargo_args(path: "imessage-exporter")
  end

  test do
    assert_equal "imessage is not a valid export type! Must be one of <txt, html>\n",
    shell_output("imessage-exporter -f imessage")
    assert_equal "Diagnostics are enabled; format is disallowed\n",
    shell_output("imessage-exporter -f txt -d")
    assert_equal "No export type selected, required by no-copy\n",
    shell_output("imessage-exporter -n")
    assert_equal "No export type selected, required by export-path\n",
    shell_output("imessage-exporter -o imessage")
    assert_equal "",
    shell_output("imessage-exporter -p imessage")
  end
end
@ReagentX ReagentX self-assigned this Dec 24, 2022
@ReagentX ReagentX pinned this issue Dec 24, 2022
@ReagentX
Copy link
Owner Author

ReagentX commented Jan 9, 2023

Brew has some pesky requirements the repo needs to meet first:

image

@ReagentX
Copy link
Owner Author

ReagentX commented Jan 11, 2023

Apparently, maintainers are not allowed to submit their own work. See the discussion here: Homebrew/homebrew-core#120503

Repository owner deleted a comment from chenrui333 Jan 13, 2023
Repository owner deleted a comment from chenrui333 Jan 13, 2023
@ReagentX ReagentX removed their assignment Jan 13, 2023
@ReagentX ReagentX unpinned this issue Jan 13, 2023
@ReagentX ReagentX pinned this issue Jan 15, 2023
@ReagentX ReagentX unpinned this issue Jan 15, 2023
@cedricloneux
Copy link

cedricloneux commented Jan 19, 2023

Brew has some pesky requirements the repo needs to meet first:

image

The requirements are for the case you want your formula to be available from brew core itself. But you can create a "tap", just as you can host your own repository on linux just by putting the formula file in the repository or another repo. That's what most projects do and give installation instruction in the main README.md

@ReagentX ReagentX added the wontfix This will not be worked on label Feb 4, 2023
@ReagentX ReagentX closed this as completed Feb 4, 2023
@cedricloneux
Copy link

It will be. I have enhanced the brew file btw.
I am still ready to provide it, with the CI/CD (GitHub actions) to automate it.

Following: #77 (comment)
Since that time, have you had time to think about what I told you about the readme file structure and build setup ? I would greatly enhance the experience of repo's visitors and you release experience too.

  • regular releases
  • no need to build and move manually
  • available via homebrew package manager
  • brew file automatically updated at each release
  • visitor know how to install at a glance and do it in a single command

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants