Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only one generated "mstile" is referenced. #267

Closed
romulof opened this issue Aug 8, 2016 · 2 comments · Fixed by RealFaviconGenerator/rfg-api#26
Closed

Only one generated "mstile" is referenced. #267

romulof opened this issue Aug 8, 2016 · 2 comments · Fixed by RealFaviconGenerator/rfg-api#26

Comments

@romulof
Copy link

romulof commented Aug 8, 2016

I've just built a new package and it has generated mstiles with the sizes:

  • 70x70
  • 144x144
  • 150x150
  • 310x150
  • 310x310

But the generated browserconfig.xml only has reference to the 150x150 one.

<?xml version="1.0" encoding="utf-8"?>
<browserconfig>
  <msapplication>
    <tile>
      <square150x150logo src="assets/icons/mstile-150x150.png"/>
      <TileColor>#844daa</TileColor>
    </tile>
  </msapplication>
</browserconfig>

And HTML snippet only has reference to browserconfig.xml.

I don't know exactly how Windows loads this files (I don't have any Windows device), but I guess it has to have some reference in the HTML or in the browserconfig.xml.

@phbernard
Copy link
Contributor

I can't reproduce the issue. I "checked everything" and I got the expected outcome:

  • The generated package contains all 5 MS tiles icons, from 70x70 to 310x310.
  • browserconfig.xml declares all Win 8.1/10 icons (ie. all icons but the 144x144 icon, which is for Win 8.0)
  • mstile-144x144.png is declared in the generated HTML.

Do I miss something?

@kb3eua
Copy link

kb3eua commented Feb 4, 2021

@phbernard I'm able to reproduce. The behavior is different between the zip file downloaded from the website and what's generated by rfg-api. In both cases all 5 icons are generated whether the corresponding checkboxes are checked or not. But there are differences in what's getting stuffed into browserconfig.xml:

  • website zip file: contains only references to the files that were checked
  • rfg-api: contains references to all 4 image files (checkboxes are being ignored)

rfg-api contains logic to convert the settings from camelCase to underscores, resulting in the following data being sent with the API request:

"windows": {
  "assets": {
    "windows80_ie10_tile":false,
    "windows10_ie11_edge_tiles": {
      "small": false,
      "medium": true,
      "big": false,
      "rectangle": false
    }
  }
}

However, this is incorrect, as the website request has underscores in front of the numbers which the API request is missing. This is how they should be formatted:

  • windows_80_ie_10_tile
  • windows_81_ie_11_edge_tile

In fact, I'm able to workaround this and get the browserconfig.xml file to respect my settings by manually adding the missing underscores to my faviconDescription.json config file, like so:

"windows": {
  "assets": {
    "windows_80Ie_10Tile": false,
    "windows_10Ie_11EdgeTiles": {
      "small": false,
      "medium": true,
      "big": false,
      "rectangle": false
    }
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants