New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manifest is missing short_name and start_url #324
Comments
I am struggling with this as well, since the short_name is also required for Web App Install banners to automatically show up:
https://developers.google.com/web/fundamentals/app-install-banners/ As a temporary solution, I've tried to get the short_name in there anyways, by making my own manifest, but I can't get the generator to stop removing it. Does anyone know how to disable the manifest generation as a temporary solutuion? I've tried with |
|
|
|
I'm afraid that might be the right choice most of the times, but sometimes erroneous. let's take a manifest that applies to a subsection of a website:
In the second case, the
My feeling is that "no value" is the most harmless default choice. |
You are absolutely right, so I would just say: provide a field to customize this, using (not set) as default value. 😀 |
It seems a little confusing, manifest is not a Android only thing. 🤔 There should be something to advice developers of what they are really creating, maybe a PWA section to clearify these points. |
The web-generated favicon
manifest.json
is missing theshort_name
andstart_url
fields, which causes Lighthouse to complain.I know this isn't strictly the purpose of a favicon generator, but it's so useful for the rest of the PWA process that it seems worth adding this in, at least optionally.
EDIT:
Sane defaults don't necessarily require changes to the UI/CLI — only the output would need to change:
short_name
could mirrorname
by defaultstart_url
should default to"."
The text was updated successfully, but these errors were encountered: