Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing newline in manifest.json and safari-pinned-tab.svg file #341

Closed
gemal opened this issue Oct 28, 2017 · 2 comments
Closed

missing newline in manifest.json and safari-pinned-tab.svg file #341

gemal opened this issue Oct 28, 2017 · 2 comments

Comments

@gemal
Copy link

@gemal gemal commented Oct 28, 2017

please add a trailing newline in the manifest.json and safari-pinned-tab.svg files. this will make it nicer when you checkin the files into git

@phbernard phbernard added this to the Package v0.16 milestone Jan 24, 2018
@phbernard
Copy link
Contributor

@phbernard phbernard commented Jan 24, 2018

Manifest: Yup!

Safari icon: Really? The one I've just generated has its ending new line. Can you reproduce?

@phbernard
Copy link
Contributor

@phbernard phbernard commented Feb 1, 2018

Manifest: done and deployed a minute ago.

Safari icon: no news is good news :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants