Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bling My Tabs: 'native' theme produces white-on-white #327

Open
LinuxOnTheDesktop opened this issue Nov 22, 2022 · 13 comments
Open

Bling My Tabs: 'native' theme produces white-on-white #327

LinuxOnTheDesktop opened this issue Nov 22, 2022 · 13 comments

Comments

@LinuxOnTheDesktop
Copy link

image

QuickFolders 5.14.
Windows 10 Pro - 21H2 (2009: 19044)
Thunderbird 102.5

@nmadani
Copy link

nmadani commented Feb 22, 2023

I am experiencing the same problem with a later version on macOS Ventura. It appears that the "Current Folder Toolbar background" setting does not work.

image

@RealRaven2000
Copy link
Owner

I am experiencing the same problem with a later version on macOS Ventura. It appears that the "Current Folder Toolbar background" setting does not work.

Could you provide a screenshot of the QuickFolders toolbar including the standard toolbar? I would like to see whether it has the same background color. Do you use a special theme (e.g. dark theme) or just the default?

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Feb 22, 2023

I believe it's a problem with the QuickFolders "apple pills" theme that it wasn't / isn't aware of dark themes and just defaulted to bright background without changing the text color to dark. I will see if I can force it to use the colors provided by the theme.

@RealRaven2000
Copy link
Owner

one more thing - here on Windows 10 I see the following, using a custom theme "metal flowers - animated":

image

If I switch to the default dark theme provided by Thunderbird, it looks like this:

image

If you can, try and activate one of these themes on Mac to see whether it makes any difference.

@nmadani
Copy link

nmadani commented Feb 22, 2023

Thank you. I applied the metal flowers animated theme. It had no impact on the appearance of the tabs:

image

@RealRaven2000
Copy link
Owner

I am experiencing the same problem with a later version on macOS Ventura. It appears that the "Current Folder Toolbar background" setting does not work.

In this screenshot you show the "Flat theme" - this has full color customization here:

Settings / Bling / Uncolored tabs:

image

There are 2 color pickers for text and background (background only in 2-colors mode)
If you select one of the three palettes (Standard / Pastel / Night Vision) you can select a preset which uses a gradient "picture" for the background. You can select the color by clicking on the preview tab:

image

image

The Current Folder toolbar is actually displayed in the center of the screen (above email preview)

image

In the example I use a custom background:

linear-gradient(to left, rgba(221,107,0,1) 0%,rgba(201,164,0,1) 14%,rgba(0,128,0,1) 33%,rgba(0,128,0,1) 33%,rgba(0,10,155,1) 50%,rgba(75,0,130,1) 66%,rgba(160,25,151,1) 84%,rgba(181,0,0,1) 100%)

What elements are shown on the Current Folder Toolbar can be configured on the Advanced tab of QF settings.

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Feb 23, 2023

@LinuxOnTheDesktop by the way the tabs are painted is under full control of the operating system - personally I use Stardock Windowblinds, so with that skinning engine, native tabs look like this:

image

What font color windows is going to use here is hard to predict (and depends on many factors such as windows customization etc.) - I think the best way forward would just be a font color picker to override what windows suggests.

@nmadani
Copy link

nmadani commented Feb 23, 2023

You were correct. It looks like a theme issue. Having found the settings under the advance tab, I did not even notice that there was a Bing My Tabs! tab. I switched to the Apple Pills theme and can see the tab labels.

@LinuxOnTheDesktop
Copy link
Author

If it matters - for, is this ostensible bug really a bug? - the same white-on-white effect occurs on Thunderbird SuperNova (115.0.1 x64) on Windows 10 (Pro - 22H2 2009: 19045) with QF 6.1pre28.

@RealRaven2000
Copy link
Owner

If it matters - for, is this ostensible bug really a bug? - the same white-on-white effect occurs on Thunderbird SuperNova (115.0.1 x64) on Windows 10 (Pro - 22H2 2009: 19045) with QF 6.1pre28.

That could just be the default background color - it uses a system variable, have you tried selecting a color:

image

@LinuxOnTheDesktop
Copy link
Author

Here is what happens when I select a 'Toolbar background'. (The pink rectangles are redaction.)

image

And ticking 'the transparency option did not help.

The colours options displayed in your screenshot, Raven, do not appear (on my system anyway) when I have 'native tabs' as the theme.

@RealRaven2000
Copy link
Owner

The colours options displayed in your screenshot, Raven, do not appear (on my system anyway) when I have 'native tabs' as the theme.

The "native..." theme really doesn't work that well - the OS paints the buttons / tabs and does whatever it thinks, there isn't much that the Thunderbird /Firefox engine can do with the background of those buttons. So you just don't have these options unless you choose the "Flat" theme - that's by design.

@RealRaven2000
Copy link
Owner

As regards "Native" buttons - The only thing I can offer is to add a color picker for the font on top of the buttons, I think that one may be customizable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants