Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dragging to folder then displays next item plus 1 instead of next item #338

Open
PeterW-gif opened this issue Jan 8, 2023 · 12 comments
Open
Assignees

Comments

@PeterW-gif
Copy link

I've just found that if I drag an item from my Inbox to one of my quick folder tabs, then the Inbox jumps one item and displays the next item plus one instead of the next item. I don't remember seeing this problem before the most recent quick folders update

@RealRaven2000 RealRaven2000 self-assigned this Jan 8, 2023
@RealRaven2000
Copy link
Owner

I have tested this here, but cannot reproduce it:

image

image

Do you have any other Add-ons installed that may modify behavior of navigation / move mail / copy mail etc?

Can you check your error console (Ctrl+Shift+J). Recommended settings:

image

You can add more output to the log by opening QF Settings / Advanced and then enabling "Debug Mode". If you right-click the Debug Mode checkbox you can enable additional detail:

image

image

Here, you may want to enable the setting extensions.quickfolders.debug.dnd = true.

You can capture the log from console with right-click on any message, then select "Copy all Messages".

image

(It would be helpful to reset the log before you test to minimize the amount of data)

@PeterW-gif
Copy link
Author

Just checking you received the emailed reply I sent you on the 8th Jan with examples of the problem. If not I'll try to post them here

@RealRaven2000
Copy link
Owner

Just checking you received the emailed reply I sent you on the 8th Jan with examples of the problem. If not I'll try to post them here

I can't recall that I got that one ... my main problem is that I cannot reproduce the behavior here - Thunderbird goes to the next (unread) message in the same folder as expected. If you replied to the github thread, your answers should end up here on this page. If the problem is reproducible, the log from error console might be helpful.

@PeterW-gif
Copy link
Author

PeterW-gif commented Jan 11, 2023

Ok I'll copy the email I sent to here and try to upload the screenshot attachments.
This is what I said:-
Hi Real Raven
Thank you for getting back to me so quickly on this.

Firstly I may have not made clear, I wasn't dragging the item from the Inbox list I was first clicking on it to open and display it. Then I dragged the displayed item to the Quick Folder. This should have caused the next item in the Inbox list to display.

But instead it was the next item plus one that displayed.

The real next item was still in the Inbox and I could then display it by clicking 'Previous' on the toolbar. So Quick folders is NOT removing that next item, it's just the display that skips one. So not a serious problem but a bit of a nuisance.

I have reproduced it and attach some screenshots to illustrate what happens. The first 'Inbox list' shows my Inbox with the item 'Re Waiting list' highlighted. The item below that is 'Save 5p off etc'.

And the one below that is 'Your order from Inc Choice'.

So I clicked on 'Re Waiting list' to open it and then dragged the opened item to the Quick Folder 'Stroll & Chat' and it moved Ok.

But instead of displaying the next item 'Save 5p off', it actually displayed the item after that 'Your order from Inc Choice' - see the next two attached displays. 'Save 5p off' is still in the Inbox list. It was just skipped for display purposes - see the screenshot 'Inbox list after moving item'.

I then re-did it all after clearing the error console and turning on debug mode as you directed. So the next screenshot is a copy of the console display this produced.

Finally, I am attaching a screenshot of all the currently enabled Thunderbird extensions.

As I initially said, I don't remember seeing this problem before, but this is the first time I have moved some emails for a couple of weeks.
Hope this is some help in getting to the bottom of it but as I said, for me, it's not a serious problem as I'm not actually losing any mails, just a nuisance to keep having to click 'Previous' to display the real next mail after moving an item.

Inbox list
![Actual Next Mail in Inbox](https://user-images.githubusercontent.com/7547
Thunderbird Enabled Extensions
2805/211805216-b035c463-e6ef-43ac-adc9-d0420592cddc.jpg)
Error Console with debug mode

Inbox List after moving item

Next Mail that actually shows

@PeterW-gif
Copy link
Author

Just a short update - I tried this after disabling all other add-ons but it still did it. Also both with previously unread emails and with previously read ones. I also notice that after moving an item to a quick folder, the next but one that appears takes a second or so to display which suggests it's being re-downloaded from the GMail server (I use IMAP). I'm sure this problem is recent but I'm not sure whether it started after either a Thunderbird update or a Quick Folders update and I don't really want the hassle of reverting back to an earlier version of either to check. I am on the latest Thunderbird release 102.6.1.

@RealRaven2000
Copy link
Owner

Firstly I may have not made clear, I wasn't dragging the item from the Inbox list I was first clicking on it to open and display it. Then I dragged the displayed item to the Quick Folder. This should have caused the next item in the Inbox list to display.

so you are talking about a tab that shows a single message? In my expectation it shouldn't actually change (it should stay on the same message) even if you move the message while on a folder tab. However I did test that here as well:

In the first image I have the mail "[quickFilters] auto - local folders" open in a separate tab. I then move this into the subfolder qFi-sub via a QuickFolders tab:

image

The single mail tab changes to the next email "Fwd: Fwd: New Statement from Amazon.com " both in the list and on the single message tab. So here it doesn't skip to the next mail following that:
image

@RealRaven2000
Copy link
Owner

Can you try the following test - what happens if you use the mail icon on the "current folder toolbar" while you are on the single message tab, to move it to another folder. Does this also skip the next mail?

image

It seems a little cumbersome to open a mail in a tab, then go back to the 3-pane window to move it. Would make more sense to move it while / after reading it. I think the actual behavior (of going to the next mail) is from Thunderbird itself, so I am not quite sure what kind of rules are applied. Note that I am using reverse chronological ordering (latest emails get appended to the bottom) and usually have threaded view enabled too.

@PeterW-gif
Copy link
Author

That's what I was doing, dragging the mail icon to a folder on the quick folders toolbar while in the single message tab. That in my system then displays the next message plus 1 in the single message tab - that is the problem. I don't go back to the Inbox list to move it, I use the mail icon to move each mail when in the single message tab.
As I said I'm sure this problem is recent but I'm not sure when it started whether after a Thunderbird update or a Quick Folders update - it could be the former that has caused it and I don't have the time to revert to previous versions of either with the possible problems that might cause.
This also happens with all other addons disabled, so they are not the cause.
But there are lots of other variables that could mean it happens on my system and not yours, e.g. I use Gmail with IMAP. I have the account syc set to keep messages in all folders for the account on my computer and to sync all messages regardless of age.
If you can't reproduce it, please don't take more of your time on it, I'm sure you have more important things to attend do. I can live with it - it just means I have to remember after dragging a message to a quick folder to then click the 'Previous' button on the mail toolbar in order to display the real next message.
Many thanks for trying anyway

@PeterW-gif
Copy link
Author

PS I also have latest messages appended to the bottom of the Inbox list but I don't use threading as I prefer to read even related messages in date received order.

@PeterW-gif
Copy link
Author

**Update with further information. I normally use Thunderbird on this PC but also have a mirror copy on my MacBook which I usually only use when away from home which I haven't been for some weeks. So I decided to see if the problem was also there. Started Thunderbird, clicked on mail in the Inbox to open it in the single message tab and then used the quick folders mail icon to drag it to a quick folder.
And then the CORRECT next item displayed in the single message pane, so the problem was not there.
But then almost immediately Quick folders updated to the latest version - which not having used the MacBook for some weeks it needed to.
I then did the same actions again but this time the INCORRECT next item plus one displayed, so the problem was now also on the MacBook version and appeared to have started after the latest quick folders update.
So I have now just on my PC downloaded and installed previous versions of Quick Folders.
My PC I saw was updated to the latest version 5.15.2 on 28th December last
So first I replaced that with version 5.15.1 and did the test but after moving a mail to a Quick folder, it still then displayed the INCORRECT next mail plus 1.
So I then downloaded and installed version 5.14 and tried again
And this time after moving a mail to a Quick folder the CORRECT next mail displays.
I have repeated this test several times and each time the CORRECT next mail now appears, i.e. the problem appears to have gone.
So it looks like it was something in the change from version 5.14 to 5.15.1 that caused it and is still there in version 5.15.2
Hope this is of some help in tracing it but if not as I said, don't worry, I can live with it.
For the moment I have disabled all add-ons auto updates (I can't find a way to just do that for Quick folders) and will keep using version 5.14 for a while to double check the problem has gone

@PeterW-gif
Copy link
Author

PeterW-gif commented Jan 20, 2023

Ok I can now confirm that reverting Quick Folders to version 5.14 HAS fixed this problem. I've been right through my Inbox dragging items in the single message tab to a quick folder using the message icon and every time the Correct next message displays in that tab. Also unlike before, there is no delay in that next message appearing - previously it took some time to appear - I thought maybe it was re-downloading from the GMail server but maybe this too was something that was part of the problem.
I looked at your list of items changed or fixed in version 5.15.1 but nothing stands out as the likely cause of the problem - the only item listed as affecting moving mails was bug fix 328
I've also found out how to just stop the Quick Folders add-on from auto updating while letting my other add-ons continue to do so.
So I will now keep using version 5.14 as long as it still works - which I guess will be until the next major TBird version change - unless in the meantime you can find what change in version 5.15.1 caused this - which if you can't reproduce the problem I accept would be difficult
PS Just extended my Pro licence for another year

@RealRaven2000
Copy link
Owner

So I will now keep using version 5.14 as long as it still works - which I guess will be until the next major TBird version change - unless in the meantime you can find what change in version 5.15.1 caused this - which if you can't reproduce the problem I accept would be difficult

Generally that shouldn't be a problem - unless you are using also the latest version of quickFilters. There are some quirks in the interaction that may lead to multiple filter assistants being displayed if you use this combination. Also 5.14 will be less efficient when moving multiple (many!) emails, as it will split up the process into multiple function calls.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants