Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retire option to set QuickFolders Bar Position in Tb115 #380

Closed
LinuxOnTheDesktop opened this issue Aug 1, 2023 · 3 comments
Closed

Retire option to set QuickFolders Bar Position in Tb115 #380

LinuxOnTheDesktop opened this issue Aug 1, 2023 · 3 comments
Assignees
Labels

Comments

@LinuxOnTheDesktop
Copy link

  1. No value that I enter into the QuickFolders Bar Position (pictured below) seems to do anything, even after pressing 'Apply position value!'. I tried 100, some positive integers, and some negative integers.

image

  1. Inputting a value only works only via the increment and decrement buttons; selecting the field and typing did nothing. Or rather that latter problem happens sometimes - I am unsure just when. Possibly the behaviour varies depending upon whether something - or which text - is highlighted within the field.

My system

QF 6.1pre28
Thunderbird 115.0.1 (x64)
Windows 10 Pro - 22H2 (2009: 19045)

@RealRaven2000
Copy link
Owner

Yeah I think that one doesn't work anymore in Thunderbird 115. I might have to retire this setting.

@RealRaven2000 RealRaven2000 self-assigned this Aug 18, 2023
@RealRaven2000 RealRaven2000 changed the title Options -> QuickFolders Bar Position seems to have no effect and intermittently the field ignores typed input Retire option to set QuickFolders Bar Position in Tb115 Aug 18, 2023
@RealRaven2000
Copy link
Owner

Remove settings from messages.json : qf.label.toolbarPosition + qf.btn.applyPosition + qf.toolbarPosition.tooltip
preference: qfpa-ToolbarPosition
legacy setting: extensions.quickfolders.toolbar.ordinalPosition
event listeners for: #applyPosition

Redesigned the Advanced panel - removed the QuickFolders Position group and moved down Updates beside Miscellanous, which was turned from horizontal to vertical flow:

image

After all code changes, we also managed to shave of 1.6kByte in code size- less code = less complexity = less sources for error.

QuickFolders-mx-6.1.2pre19.zip


To test the version above, download the zip file, drag into Thunderbird Add-ons Manager, do not extract contents or if won't install.

@RealRaven2000
Copy link
Owner

Implemente in 6.2 - Published 30/08/2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants