New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make QuickFolders compatible with Thunderbird 78 ESR #8
Comments
Here is a quick-fix for the "removed label" problem; this was caused by some faulty tidy up of old menus in the function addPopupSet:
I have fixed this by adding && tagname == "menupopup" to the conditional |
Another regression: the search box of the quickMove panel doesn't work. I replaced the (deprecated) textbox with a search-textbox element - for this, I had to split out the tool panel into a separate XUL file. There is still a new issue with loading the reading list which is caused by this fix. test version: |
When moving files with quickMove, there is an exception that fails querying the folders ti the nsIRDFResource interface. I was able to remove the references, so the quickMove function works again - fixed version, tested in 72.0a1 Daily (2019-111-01): |
I created the new branch ESR78 and have started the conversion process, for real. I estimate about 3-5 weeks. |
Timeline: we intend to be ready by end of September, when 78.2 is auto-rolled out to the Tb68 users base. Please do not upgrade until then. What happened - @jobisoft helped me and @opto with the first hard conversion step to a mail experiment with QuickFolders. We will finish that one first so that it runs completely with only minor functionality loss. Then we will apply the same changes to quickFilters (similar codebase) and last SmartTemplate⁴. |
I had to abandon branch ESR78 because it was too chaotic. Created a new branch here: and now following John Bieling's update guide, here: |
Would be happy to beta-test for Thunderbird 78. |
I too would be happy to beta-test for TB78. |
Hi, I am opto - Klaus. I am updating Quickfolders together with Axel. We just made a major - if preliminary breakthrough. As a start, we are putting the new technology into 68. Later, we will transpose that to 78. Now, as of today, the new technology can in 68:
This all works with the new addon technology and can be easily (???) ported to 78. Well, not really easily, but we are promised it will be possible. If you want to help with testing, that is very welcome: install a test 68.10 (that is what I am using) test and report any issues - likely, there will be many, but still, it starts to come together. enjoy, Klaus |
RemoveDupes also uses this two-step upgrade process and the developer reported that the final step into TB78 required only little changes. Strategy is looking good! |
and THANKS !! to John for his help |
Here is a first prerelease (beta) of the new QuickFolders, based on non-legacy code, It's only tested in Thunderbird 68.10 / 68.11 yet; probably some stuff still missing, but it's useable: To install, please unpack the contained xpi to hard drive. then pull the xpi file into Add-ons Manager. Important: This is not tested in Tb78 yet! but it uses methods that (so we are told) are forward compatible. We will see what particular things break once we have completed work on 68 first - for safety we are sticking to the conversion guide here: PS: This current source code is in Klaus' branch at |
dito from me! My next plan is to get SmartTemplate4 to the same stage quickly... (Some) users are already screaming for it. |
Here is another preview version, based on opto's esr method branch which works partly in Thunderbird 78: To install, please unpack the contained xpi to hard drive. then pull the xpi file into Add-ons Manager. What it already does in Thunderbird78:
What doesn't work yet (Tb78):
|
Here is the next prerelease version. We are having some toruble with the foldertree (I bypassed the code for now) and still no drag and drop, But most dialogs (options / register / categories / change order) work properly now. This version only works in Thunderbird 78 or higher. To install, please unpack the contained xpi to hard drive. then pull the xpi file into Add-ons Manager.
|
And another: I fixed the icon issue in foldertree: To install, please unpack the contained xpi to hard drive. then pull the xpi file into Add-ons Manager.
getting closer. |
New version - another milestone. Thunderbird 78 only! To install, please unpack the contained xpi into a hard drive folder. then pull the xpi file into Thunderbird Add-ons Manager.
known issues:
|
Next version - prerelease 54: To install, please unpack the contained xpi into a hard drive folder. then pull the xpi file into Thunderbird Add-ons Manager.
To do next:
|
Here is the latest update with style related and functional fixes: To install, please unpack the contained xpi into a hard drive folder. then pull the xpi file into Thunderbird Add-ons Manager.
To do next:
|
Here is the latest update with the new skinnable icons (supports theming colors) These icons were created by @Paenglab - many thanks for the beautiful work! To install, please unpack the contained xpi into a hard drive folder. then pull the xpi file into Thunderbird Add-ons Manager. Fixed:
Known issues:
|
After improving some of the icons, here is the latest version: To install, please unpack the contained xpi into a hard drive folder. then pull the xpi file into Thunderbird Add-ons Manager. |
Since all updates after 5.7 there is only one line of quick folder tabs shown in Thunderbird, so I have had to revert always to 5.7. I have quite a few lines as I have several mail accounts. I have tried finding a setting that say allow multiple lines but cannot. |
5.7? you probably mean pre 57 - I see... yeah they need to wrap, that's a regression right there... what's the last versioon where it works? |
are you sure it is not Shift+M? |
Some of the shortcuts are probably taken by Thunderbird themselves (I know for a fact that M toggles unread status on my Tb68, so I am surprised it doesn't do that on yours). Anyway if you want a shortcut without Shift you have to look for a different letter. Thunderbird probably won't allow us to overwrite the built in keyboard shortcuts. |
Many thanks for replying quickly. You are right. It is indeed surprising 'm' has worked so far. I'll choose another lower case letter after checking it is not used by TB. |
Hello again, pre71 pre84 I can provide more information if needed. Regards. |
It sounds like a regression - @opto pointed out to me that the use of keyCode was deprecated so he changed it to "charCode" in the last patch, I am going to test that now... |
Actually both are deprecated. Use https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/code instead. |
quickMove and quickJump issue fixed in 5.0pre87. |
That's correct, none of the settings starting with "qf" should actually be in the config database (I only use these internally to categorize different setting groups), so there are definitely some major fixes necessary still. All user specific preferences should start with
I am hoping to get some assistance from @jobisoft early next week to fix this issue. Maybe we will switch to local storage for good, but I want to be able to still see changes (instantApply) visually in the toolbar while the options dialog is open. |
i installed the quickfolders from below url, but I don't see it picked up my previous configurations and folder colors as it shows nothing. Is there way to copy or backup the configuration from older thunderbird quickfolders extension and restore it new thunderbird(78.2)? I don't want to manually create folders/colors. https://github.com/RealRaven2000/QuickFolders/releases/tag/5.0pre71 |
Here is a new pre-release. The preferences system was borked, we fixed it with @jobisoft today: https://github.com/RealRaven2000/QuickFolders/releases/tag/5.0pre90 |
There is a new prerelase available, please see: https://github.com/RealRaven2000/QuickFolders/releases/tag/5.0pre100 |
After @Vacoas sent me en error log I found the problem can be reproduced by opening the QuickFolders options dialog through the Add-ons / Tools menu. Some code that is designed to preselect a tab (and possibly hide others) in this dialog fails because of the window arguments parameter being passed having an unexpected length; this also leads to the license validation misfiring. It will be fixed in the next pre-release. |
Discovered an issue with the category manger not loading due to missing namespace for the new html input controls. I have already fixed this and am going to add this to the next prerelease. In the meantime, the very latest beta version can be found here: https://github.com/RealRaven2000/QuickFolders/releases/tag/5.0pre116
|
pre116 works nicely here. It found all folders I used in the old version. Environment is Debian 10.6 and TB 78.4.0 64 Bit. |
My Thunderbird upgraded itself to 78.4.0 in Windows 10 and the pre116 release solved my problems. I downloaded the .xpi file and then went into TBird Add-on Manager. Using drag and drop I was able to install the file successfully. Thanks. |
Latest prerelease solving the broken category dialog mentioned in issue #68: https://github.com/RealRaven2000/QuickFolders/releases/tag/5.0pre119 |
I believe 78.4 was not optional anymore but rolled out to a lot of users, maybe all? |
just want to say a big thank you - so helpful! |
Released 5.0 for Thunderbird 78 - 17/11/2020 (currently waiting for approval on ATN) if you don't have a pro license get the Black Friday bargain 19/Nov - 29/November! - or get one for a friend! |
That's good and indeed I received a pop-up in Thunderbird and I renewed my license. However, your webpage and version history page do not mention version 5.0. I imagine that that is so because of the approval that you mention you are waiting on. Still, it would be good to do all those things in one go, such that users do not get automatically upgraded to 5.0 until there is a release announcement on the website. That said, perhaps I got upgraded only because I was using a beta. |
Well they don't do it on top of the page, but new versions are jumped to in a thunderbird tab via a version tag, see: you are automatically updated from any previous version number (as long as the Add-on is compatible with your current version of Thunderbird). according to the version comparison algorithms: 5.0 > 5.0pre120 > 5.0pre56 > 4.12 |
Closing issue, with version 5.1 released on we are fully compatible with Thunderbird 78 |
This issue is specifically for handling all compatibility problems in Thunderbird 70. Feel free to add more bugs specific to this version below.
The text was updated successfully, but these errors were encountered: