Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

%header.set(to,"[addressee]")% no longer working #98

Closed
JohnFLand opened this issue Nov 29, 2020 · 7 comments
Closed

%header.set(to,"[addressee]")% no longer working #98

JohnFLand opened this issue Nov 29, 2020 · 7 comments
Assignees

Comments

@JohnFLand
Copy link

JohnFLand commented Nov 29, 2020

A template of mine that worked fine before the 2020 updates to TB (I'm now on TB 78.5.0) no longer inserts an addressee. The text for the body of the email is inserted fine. Here's the entire template:

%header.set(to,"John Smith <johnsmith@domain.com>")%
<p>John --</p>
<p>%cursor%</p>
%sig(html)%

Is there a workaround?

@RealRaven2000
Copy link
Owner

A template of mine that worked fine before the 2020 updates to TB (I'm now on TB 78.5.0) no longer inserts an addressee. The text for the body of the email is inserted fine. Here's the entire template:

%header.set(to,"John Smith <johnsmith@domain.com>")%
<p>John --</p>
<p>%cursor%</p>
%sig(html)%

Are you using that in a reply template or in a write (compose new)? I am not sure if I tested this a lot with "new mail" so that may be related.

That looks like regression, needs to be fixed ASAP. I will post a beta here as soon as it's done!

@RealRaven2000 RealRaven2000 pinned this issue Nov 30, 2020
@JohnFLand
Copy link
Author

JohnFLand commented Nov 30, 2020 via email

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Nov 30, 2020

This template (and similar templates) is for composing new messages. Most of my new emails go to a small collection of individual addressees. Not having a problem with replies.

Thanks for clarifying. It would make sense as the addressing-widget has changed and I think there is some special trickery going on for that composition case. I see that there is some rewriting necessary in "modifyHeader( ) " function to work with the new addressing widget toAddrContainer the old one was a listbox addressingWidget which contained multiple items. Will post a beta here soon.

@RealRaven2000
Copy link
Owner

OK, I got one for you - can you try out this version please:
smartTemplate-fx-3.2pre2.zip

To install, download and drag the file into Thunderbird Add-ons Manager.

My test template (write new case)

%header.set(to,"John Smith <johnsmith@domain.com>")%
%header.set(cc,"Axel Smith <axesmith@domain.com>")%
<p>Dear %to(firstname)% --</p>
<p>%cursor%</p>
%sig(html)%

result:
image

I also test with an additional line
%header.append(to,"Real Raven <rr2k@hotmail.com>")%
and this will fill 2 addressees into the to line as expected:

image

@JohnFLand
Copy link
Author

JohnFLand commented Nov 30, 2020 via email

@RealRaven2000
Copy link
Owner

Great, I will leave this open until I officially release 3.2 in case somebody else is looking for this!

@RealRaven2000
Copy link
Owner

Implemented in version 3.2 - released on 17/Dec/2020

This is currentlay awaiting official review on ATN.

@RealRaven2000 RealRaven2000 unpinned this issue Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants