Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replying to a replied-to email removes previously replied text #39

Closed
ckeydel opened this issue Jan 24, 2020 · 8 comments
Closed

Replying to a replied-to email removes previously replied text #39

ckeydel opened this issue Jan 24, 2020 · 8 comments
Assignees
Labels

Comments

@ckeydel
Copy link

ckeydel commented Jan 24, 2020

Often, I follow-up on emails that I have previously answered and if there hasn't been another reply from the contact in the meantime I use my own reply for the follow-up so that my previous answer is kept. For that, I use "Reply" or "Reply-all" on my last sent email.

With ST4 enabled, in most cases this will completely remove the text I added to my previous reply, so in the email I see the original email from the contact, my added header from my previous response but not the previous signature and also not the previous text. I can understand that the signature is removed (even that should be an option, though), but my previous text is essential and must not be silently removed (well, the removal is silent, my reaction is not! ;-)). In this example, the highlighted space marks where the previous text and signature was removed:

image

This happens often, but not always and I haven't figured out the mechanics behind it. Nothing terribly complicated or advanced in my settings for the affected accounts either, e.g.:

image

It doesn't happen if I keep the shift key pressed to generate a plain-text reply email, but this is usually not an option.

@ckeydel

This comment has been minimized.

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Jan 24, 2020

Follow-up: Curiously, the location where the text is removed is where TB puts the file link if I use the FileLink feature:

I would expect this to happen above the new signature where I added my new text. Which is what TB does when I disable ST4 (just checked). So, there appears to be several issues with such emails when ST4 is used.

Can you open a separate issue for the filelink stuff?

@RealRaven2000
Copy link
Owner

With ST4 enabled, in most cases this will completely remove the text I added to my previous reply, so in the email I see the original email from the contact, my added header from my previous response but not the previous signature and also not the previous text. I can understand that the signature is removed (even that should be an option, though), but my previous text is essential and must not be silently removed (well, the removal is silent, my reaction is not! ;-)). In this example, the highlighted space marks where the previous text and signature was removed:

this is very strange and unexpected. can you post your template text? SmartTemplate is not supposed to touch anything within the <blockquote> element.

I suspect it's a side effect of the "toxic" setting "Replace line breaks with <br>".

image

I wish I had removed that setting 7 years ago when I took over development. Can you please disable this and insert <br> like in a proper HTML code?

In any case, please export your settings with the "Save Template..." button and attach to the comment:

image

@ckeydel
Copy link
Author

ckeydel commented Jan 24, 2020

Just unchecked that option and no change, it still happens. Attached the exported template.
myemail@mydomain - My Name.zip

BTW my TB version is 60.9.1 (64-bit). Perhaps it is some unusual HTML in my signature that's tripping it? The default signature (HTML) is

<div class="moz-signature">
<font face="Helvetica, Arial, sans-serif">
<p style="color:black">
<br>
<small>Chris
</small></font>
</div>

Update: It also happens when I remove the moz-signature tag.

@ckeydel
Copy link
Author

ckeydel commented Jan 24, 2020

It seems that "simple" emails and emails between TB users are not affected. For example, I replied to the GitHub notification email and put your email address in, sent that. I can reply to that sent email no problem, all the text is there. But most other email originally from god-knows-what email client, the problem happens. So my assumption is that it is "something" in the original emails that is carried over to the replies makes this fail.

@RealRaven2000
Copy link
Owner

RealRaven2000 commented Jan 24, 2020

Just unchecked that option and no change, it still happens. Attached the exported template.
myemail@mydomain - My Name.zip

BTW my TB version is 60.9.1 (64-bit). Perhaps it is some unusual HTML in my signature that's tripping it? The default signature (HTML) is

<div class="moz-signature">
<font face="Helvetica, Arial, sans-serif">
<p style="color:black">
<br>
<small>Chris
</small></font>
</div>

I can see your problem right there. You are missing the closing </p> tag. I think that causes major confusion to Thunderbird.
Also, please get rid of <font> ! it's deprecated. instead put the font properties in a separate style tag or as part of the <div>.

try this instead:

<div id="myTemplate" style="font-family:Helvetica, Arial, sans-serif; color:black">
  <p>
    %cursor%
    <br>
  </p>

  <div class="moz-signature">  
    <small>Chris
    </small>
  </div>
</div>

Edit: you MUST remove the class (moz-signature) from where you type. Thunderbird replaces this block completely when you select a different identity. If you think about it, you are actually asking Thunderbird to remove everything!

@RealRaven2000
Copy link
Owner

Pretty sure I can flag this one as invalid. The behaivor is actually by design, and it's Thundebird's behavior.

@ckeydel
Copy link
Author

ckeydel commented Jan 24, 2020

Agreed, the moz-signature was tripping it. Removing it made it work as intended. Thanks!

@ckeydel ckeydel closed this as completed Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants