Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix warning during initialization" #237

Closed
wants to merge 1 commit into from

Conversation

AlexHartford
Copy link
Contributor

Reverts #236

Apparently DatePickerTheme was updated where backgroundColor is non-nullable, so now this PR created a warning instead of removing it.

./../../../.pub-cache/hosted/pub.dartlang.org/flutter_datetime_picker-1.5.1/lib/flutter_datetime_picker.dart:311:32: Warning: Operand of null-aware operation '??' has type 'Color' which excludes
null.
 - 'Color' is from 'dart:ui'.
                  color: theme.backgroundColor ?? Colors.white,

@AlexHartford
Copy link
Contributor Author

Nevermind, it seems the original PR just didn't get deployed.

@hyouuu
Copy link

hyouuu commented May 18, 2021

@AlexHartford without this PR I still see the issue - should we reopen this?

@AlexHartford
Copy link
Contributor Author

@hyouuu No, the reason you still see the issue is that the package author never pushed a new version of the package containing the fix.

@hyouuu
Copy link

hyouuu commented May 18, 2021

Gotcha guess I'll point to the git branch then. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants