Allow to disable a column in a layout + time picker optional seconds #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 for this PR, any reason it's not merged yet? |
|
Please merge this if validated, it's very useful |
|
I also need this feature. We don’t need the seconds feature for setting a notification time for example. |
|
It looks great, sorry for all for my late PR review, thanks |
|
Great, thanks for merging that! Would it be possible to update the pub package as well? :) |
|
Hi like this feature. Is it possible to disable it from user modification but still display the current value? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, it's me again^^
I noticed that a picker must have 3 columns, but in some case you may want only two (for example in a time picker without the seconds column).
With this commit, setting a column's layout proportion to 0 will disable the column completely (without needing to do weird proportions like [100, 100, 1]).
That created an opportunity for a "showSecondsColumn" property in the TimePickerModel that would enable/disable the seconds column, so I implemented it too. :) Apparently, this is a feature that is requested by several people: #61 #45
Finally, I fixed the warnings created by my previous commit.
Have a good day,
Martin