fix: use replace state instead of pushState

fixes #244
Redocly · Mar 31, 2017 · 4f4e748 · 4f4e748
1 parent b9740bf
commit 4f4e748
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/lib/services/hash.service.ts b/lib/services/hash.service.ts
@@ -27,8 +27,12 @@ export class Hash {
     });
   }
 
-  update(hash: string|null) {
+  update(hash: string|null, rewriteHistory:boolean = false) {
     if (hash == undefined) return;
+    if (rewriteHistory) {
+      window.history.replaceState(null, '', '#' + hash);
+      return;
+    }
     this.noEmit = true;
     window.location.hash = hash;
     setTimeout(() => {

diff --git a/lib/services/menu.service.ts b/lib/services/menu.service.ts
@@ -202,14 +202,14 @@ export class MenuService {
     }
   }
 
-  activate(idx, force = false) {
+  activate(idx, force = false, replaceState = false) {
     let item = this.flatItems[idx];
     if (!force && item && !item.ready) return;
 
     this.deactivate(this.activeIdx);
     this.activeIdx = idx;
     if (idx < 0) {
-      this.hash.update('');
+      this.hash.update('', replaceState);
       return;
     }
 
@@ -220,14 +220,14 @@ export class MenuService {
       cItem.parent.active = true;
       cItem = cItem.parent;
     }
-    this.hash.update(this.hashFor(item.id, item.metadata, item.parent && item.parent.id));
+    this.hash.update(this.hashFor(item.id, item.metadata, item.parent && item.parent.id), replaceState);
     this.changedActiveItem.next(item);
   }
 
   changeActive(offset = 1):boolean {
     let noChange = (this.activeIdx <= 0 && offset === -1) ||
       (this.activeIdx === this.flatItems.length - 1 && offset === 1);
-    this.activate(this.activeIdx + offset);
+    this.activate(this.activeIdx + offset, false, true);
     return noChange;
   }