feat: support for xml samples in response when there is no schema in …

…response closes #307
Redocly · Aug 2, 2017 · eb7089b · eb7089b
1 parent 2c89536
commit eb7089b
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/lib/components/ResponsesSamples/responses-samples.ts b/lib/components/ResponsesSamples/responses-samples.ts
@@ -3,16 +3,15 @@
 import { Component, Input, OnInit, ChangeDetectionStrategy } from '@angular/core';
 import { BaseComponent, SpecManager } from '../base';
 import JsonPointer from '../../utils/JsonPointer';
-import { statusCodeType, getJsonLikeSample } from '../../utils/helpers';
+import { statusCodeType, getJsonLikeSample, getXmlLikeSample } from '../../utils/helpers';
 
 
 function isNumeric(n) {
   return (!isNaN(parseFloat(n)) && isFinite(n));
 }
 
 function hasExample(response) {
-  return ((response.examples && getJsonLikeSample(response.examples)) ||
-    response.schema);
+  return response.schema || getXmlLikeSample(response.examples) || getJsonLikeSample(response.examples)
 }
 
 @Component({

diff --git a/lib/components/SchemaSample/schema-sample.html b/lib/components/SchemaSample/schema-sample.html
@@ -12,7 +12,7 @@
 </ng-template>
 
 <tabs *ngIf="xmlSample; else jsonSnippet">
-  <tab tabTitle="JSON">
+  <tab tabTitle="JSON" *ngIf="sample">
     <ng-container *ngTemplateOutlet="jsonSnippet"></ng-container>
   </tab>
   <tab tabTitle="XML" *ngIf="xmlSample">

diff --git a/lib/utils/helpers.ts b/lib/utils/helpers.ts
@@ -142,7 +142,7 @@ export function isXmlLike(contentType: string): boolean {
   return contentType.search(/xml/i) !== -1;
 }
 
-export function getJsonLikeSample(samples: Object) {
+export function getJsonLikeSample(samples: Object = {}) {
   const jsonLikeKeys = Object.keys(samples).filter(isJsonLike);
 
   if (!jsonLikeKeys.length) {
@@ -152,7 +152,7 @@ export function getJsonLikeSample(samples: Object) {
   return samples[jsonLikeKeys[0]];
 }
 
-export function getXmlLikeSample(samples: Object) {
+export function getXmlLikeSample(samples: Object = {}) {
   const xmlLikeKeys = Object.keys(samples).filter(isXmlLike);
 
   if (!xmlLikeKeys.length) {