Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redoc sidemenu overlaps page footer #75

Closed
IvanGoncharov opened this issue Aug 2, 2016 · 11 comments
Closed

Redoc sidemenu overlaps page footer #75

IvanGoncharov opened this issue Aug 2, 2016 · 11 comments
Assignees

Comments

@IvanGoncharov
Copy link
Contributor

image

@krsyoung
Copy link

krsyoung commented Aug 23, 2016

Hey @RomanGotsiy, looks like it has the same issue with overlapping a navbar as well (when using Zurb foundation).

I seem to be able to workaround it by changing the position from fixed to absolute here:

<div _ngcontent-ift-1="" class="menu-content" sticky-sidebar="" style="position: absolute; top: 0px; bottom: 0px; max-height: 100%;">
                ...
            </div>

I'll keep investigating to see what else this breaks :-)

@RomanHotsiy
Copy link
Member

@krsyoung does ReDoc overlaps navbar of footer? If it overlaps navbar: have you tried using scroll-y-offset option of ReDoc?
Check out example

@krsyoung
Copy link

Hey @RomanGotsiy, thanks for the pointer! This helps but (in my case) I don't have a sticky navbar so I end up with a gap the size of the navbar as soon as I scroll down the page. It does look perfect when the page initially loads using the scroll-y-offset option and body > header in my case.

I'll keep messing with it, you've got me going in the right direction.

@RomanHotsiy
Copy link
Member

@krsyoung it would be helpful if you can share link to your site so I can check it and fix this issue

@RomanHotsiy
Copy link
Member

I mean nothing is wrong with your setup. It is ReDoc issue and I'm interested to fix it to cover as many as possible common use cases

@krsyoung
Copy link

Hey no worries @RomanGotsiy, I've got lots of issues! Will have a link for you later today. Appreciate the help. -- BTW I can open another issue if you want to track separately.

@krsyoung
Copy link

Hey @RomanGotsiy, here is a link to the site with the issue: http://169.44.121.154/docs/api

It is based on Zurb Foundation. I didn't have a chance to look at it today but hopefully will tomorrow.

@RomanHotsiy
Copy link
Member

@krsyoung I have checked your link.
It's ReDoc issue, nothing wrong with your setup. I will try to fix this for the next release (most likely at the beginning of the next week)

RomanHotsiy added a commit that referenced this issue Aug 30, 2016
@RomanHotsiy
Copy link
Member

@krsyoung I have fixed navbar overlaps. Remove scroll-y-offset from <redoc> element on your site to get it working.

Regarding footer overflow - will fix this for the next release.

@RomanHotsiy
Copy link
Member

@IvanGoncharov @krsyoung this issue is fixed in the latest release: v1.3.0
I have checked both sites and side menu no more overflows page footer

@krsyoung for you site you need to remove scroll-y-offset option from <redoc>

@krsyoung
Copy link

krsyoung commented Sep 9, 2016

Beautiful, for the record thanks @RomanGotsiy! Things are looking great at https://apiharmony-open.mybluemix.net/docs/api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants