added citation field to create source #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Marie000
commented
Feb 5, 2021
| @@ -79,6 +79,7 @@ | |||
| const body = Object.fromEntries( | |||
| new URLSearchParams(new FormData(target)).entries() | |||
| ); | |||
| if (body.citation) body.citation = {default: body.citation} | |||
There was a problem hiding this comment.
I don't know if that was the right place to do that.
There was a problem hiding this comment.
Long term, the update, create, and delete functions for a source should be consolidated into a Source model but we aren't there yet so, in the meantime, this place is as good as any 🙂
baldurbjarnason
approved these changes
Feb 8, 2021
| @@ -79,6 +79,7 @@ | |||
| const body = Object.fromEntries( | |||
| new URLSearchParams(new FormData(target)).entries() | |||
| ); | |||
| if (body.citation) body.citation = {default: body.citation} | |||
There was a problem hiding this comment.
Long term, the update, create, and delete functions for a source should be consolidated into a Source model but we aren't there yet so, in the meantime, this place is as good as any 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So I think it works. I am not completely sure because I still get that bug where I can't click on the (i) icon to see the source metadata. But I checked that the body sent to the API contains citation: {default: '....'}