Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order created with different range amount that specified #112

Closed
zx9r opened this issue Apr 27, 2022 · 3 comments · Fixed by #110
Closed

Order created with different range amount that specified #112

zx9r opened this issue Apr 27, 2022 · 3 comments · Fixed by #110

Comments

@zx9r
Copy link
Contributor

zx9r commented Apr 27, 2022

Describe the bug
I have created a sell order with range amount 50-125 EUR, however the published order has a range of 50-130

To Reproduce
I guess just creating an order with said parameters, didnt try repeating though

Expected behavior
Published order should have the amount range specified by the user

Screenshots
In the following screenshot the range 50-130 can be seen:

image

However, the range was created as 50-125, as can be seen in the following screenshot from the invoice memo:

image

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser: Tor Browser
  • Version: 11.0.10 (based on Mozilla Firefox 91.8.0esr) (64-bit)
@Reckless-Satoshi
Copy link
Collaborator

Thanks for reporting @MishoKanaria !

Seems to be a rounding issue on the front end (it rounds to precision of two digits).
https://github.com/Reckless-Satoshi/robosats/blob/ba9bc16b531b86f8448cdae1308c57e84cb391eb/frontend/src/components/OrderPage.js#L535
Yet the order is exactly 50-125 (the description of the invoice is always right).

The precision is set to only 2 since this the max precision allowed by the Make Order slider. However, we then introduced the textfield that allows users to input any arbitrary number. So I assume you entered the 125 manually on the textfield.

Easy fix, let's increase precision in the order details page :)

@zx9r
Copy link
Contributor Author

zx9r commented Apr 29, 2022

Yep, I dont remember If I entered the 125 manually but I guess you are right

BTW, who is MishoKanaria ? ;)

@Reckless-Satoshi
Copy link
Collaborator

BTW, who is MishoKanaria ? ;)

Wops! :D The automatic recommended @tag played with me ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants