Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send correct status message when OrderView is called #17

Closed
Reckless-Satoshi opened this issue Jan 3, 2022 · 0 comments
Closed

Send correct status message when OrderView is called #17

Reckless-Satoshi opened this issue Jan 3, 2022 · 0 comments
Labels
good first issue Good for newcomers
Milestone

Comments

@Reckless-Satoshi
Copy link
Collaborator

The Status choices are named WFB, PUB, etc. However, these encode for a order status number (0,1,2..) and a status message ('Waiting for bond', 'Published'...). Frontend should receive the message in the reply, not only the number.
Fix goes around here:
https://github.com/Reckless-Satoshi/robosats/blob/a61eb217b537aa0c068ecbfc90a1cf1d3ff672e2/api/views.py#L82-L83

@Reckless-Satoshi Reckless-Satoshi added the good first issue Good for newcomers label Jan 3, 2022
@Reckless-Satoshi Reckless-Satoshi added this to the v0.1.0 MVP milestone Jan 3, 2022
@turizspace turizspace mentioned this issue Aug 26, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant