Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add matchmaking system #237

Closed
Reckless-Satoshi opened this issue Sep 10, 2022 · 1 comment
Closed

Add matchmaking system #237

Reckless-Satoshi opened this issue Sep 10, 2022 · 1 comment
Labels
enhancement 🆙 New feature or request

Comments

@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Sep 10, 2022

Is your feature request related to a problem? Please describe.
While uncommon, makers might create orders that already have an exact match in the book. A light matchmaking system similar to that of Peach can help gamify a bit more the experience and help users find offers.

Describe the solution you'd like
I envision the matchmaking could take place in two ways.

The straightforward way (1): this one has been discussed for over 6 months now. It would be easy to add on the current user workflow. A request is sent to the backend just after using the MakerPage, it returns "Order you might be interested". This will be just a short list of orders for the exact same payment method(s) and about the same amount. Then the user can "match" one of those or click "Create a new order".

The new user workflow way (2): can be implemented with the UserGen redesign #204 , the Order Book would be the first thing a user sees. Then he can click on an order and the robot avatar generation pipeline will start. Alternatively, he could click on "make order" and after he customizes the new order he will be given possible matches. If no match is liked by the user, he can "publish new order".

The orders given by the matchmaking system could be shown in two ways. (a) As cards that the user can swipe around (left/right) and click "match" for the one they like (this is the Peach approach, pretty cool, a bit like Tinder). Or (b) in a data table, where users can see every order, easily compare them and tap on the one they like (this is "less fun" but more practical: swiping cards around and remembering premium, amounts and payment methods is a challenge for human's short-term memory).

Additional context

I would personally favor optiion 2 (new user workflow) and I am unsure whether I like more a or b (swipe cards vs table view).

If the matchmaking happens over the Order Book data-grid, we will only need to implement frontend filters. If we want something more complex with more clever algorithms, a new API endpoint will have to be created.

@Reckless-Satoshi
Copy link
Collaborator Author

This feature has already been merged as part of the new MakerPage component #265

The frontend will match the MakerForm with the Order book in the state and offer up to 4 orders to select from if there is a match in: currency, trade direction, amount and payment methods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🆙 New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant