New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Load all important application hparams from .env file on root dir #8

Closed

2 tasks

Reckless-Satoshi opened this issue Jan 2, 2022 · 0 comments

Labels

good first issue

Milestone

Collaborator

Reckless-Satoshi commented Jan 2, 2022

There are many hyperparameters that could be centralized into an .env in the root directory to ease the application managing
For example, limits for trade size could be imported from .env
https://github.com/Reckless-Satoshi/robosats/blob/9335e6abbe797e4fb281d7280da3a7114c7ef03b/api/models.py#L9-L10

Create an .env-sample file on root directory (e.g. MIN_TRADE_LIMIT, LND_CERT, LND_MACAROON, MAX_CONCURRENT_TRADES, INVOICE_EXPIRATION_WINDOW, ORDER_PUBLISHED_EXPIRATION_WINDOW, FIAT_RATE_API_NAME, FIAT_RATE_API_URL)
Substitute most important variables for those moved .env in the whole project

The text was updated successfully, but these errors were encountered:

Reckless-Satoshi added the good first issue label

Reckless-Satoshi added this to the v0.1.0 MVP milestone

Reckless-Satoshi changed the title ~~Read app hparams from .env file~~ Load all important application hparams from .env file on root dir

Reckless-Satoshi closed this as completed

turizspace mentioned this issue

Create sw.json #814

Closed

1 task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment