Remove built main.js from versioning #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should never version built files. This leads to conflicts when merging branches. This commit deletes the main.js file and changes the .gitignore to prevent it from being added again
|
Thanks @fernandoporazzi LGTM, merging! It was a hassle for development and checking out branches. Yet it made it easy for deployment on the production platform since "git pull" was enough (no need to have the dependencies needed to build it). I will figure out an alternative pipeline for deploying into production. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should never version built files. This leads to conflicts when merging branches.
This commit deletes the main.js file and changes the .gitignore to prevent it from being added again