Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pl.json #105

Merged
merged 5 commits into from
Apr 24, 2022
Merged

pl.json #105

merged 5 commits into from
Apr 24, 2022

Conversation

valladolidBTCpol
Copy link
Contributor

No description provided.

@valladolidBTCpol
Copy link
Contributor Author

polish translation

@valladolidBTCpol valladolidBTCpol changed the title Patch 1 pl.json Apr 23, 2022
@Reckless-Satoshi
Copy link
Collaborator

Hey @valladolidBTCpol, really awesome you opened this PR for a Polish translation! Ping me when you think it is ready for review and merge :D

@valladolidBTCpol
Copy link
Contributor Author

@Reckless-Satoshi I think it's done

@Reckless-Satoshi
Copy link
Collaborator

I will be testing and merging later today. Unfortunately, I do not think we have anyone able to review your work in Polish. :)

@Reckless-Satoshi Reckless-Satoshi merged commit e2e939b into RoboSats:main Apr 24, 2022
@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Apr 24, 2022

Hey @valladolidBTCpol ,

Thanks for the huge sprint to get this translation done!! 👏👏👏

You can see it running in Testnet (it is sometimes down).

If you could, take a look on the places where the new text break the UI. For example, the homepage buttons become double line in the mobile view. Also some headers of the contract box become double line (you can create a dummy order to check the contract box). Probably some cannot be fixed, but maybe you find an easy way to make these shorter since translations often do not need to be literal. For example "Make order" and "View book" buttons could simply be "make" and "take" if that makes the new language fit.

@valladolidBTCpol
Copy link
Contributor Author

@Reckless-Satoshi Perfect.
I'll get with it on Saturday and Sunday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants