Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

de.json #108

Merged
merged 7 commits into from
Apr 27, 2022
Merged

de.json #108

merged 7 commits into from
Apr 27, 2022

Conversation

dsitti
Copy link
Contributor

@dsitti dsitti commented Apr 24, 2022

work in progress

@dsitti
Copy link
Contributor Author

dsitti commented Apr 25, 2022

From my side, it´s now ready to marge in to the testnet for a final review.

@Reckless-Satoshi
Copy link
Collaborator

From my side, it´s now ready to marge in to the testnet for a final review.

Awesome! Will be up in testnet in a few hours.

Amazing contribution!

@Reckless-Satoshi
Copy link
Collaborator

Hey @dsitti

It is up in testnet! :)

Similar comment to the other translations:

There are some places where the new text breaks the UI. For example, the homepage buttons become double line in the mobile view (not too relevant, just an example). Also some headers of the contract box become double line (you can create a dummy order to check the contract box).

Any translation that takes more lines can lead to some parts of the UI being no longer visible (specially in small screens). Maybe you find an easy way to make these shorter, since translations often do not need to be literal. For example "Make order" and "View book" buttons could simply be "make" and "take" if that makes the new language fit. Some strings might be impossible to shorten, that's okay :)

Once again, thank you very much for this valuable contribution!

@Reckless-Satoshi Reckless-Satoshi merged commit c9e1dce into RoboSats:main Apr 27, 2022
@Reckless-Satoshi
Copy link
Collaborator

@dsitti Looks great! It will be up in the mainnet platform in the next upgrade this weekend

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants