Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix layout for small iOS devices and allow scroll #130

Merged

Conversation

ozoono
Copy link
Contributor

@ozoono ozoono commented May 8, 2022

Add css styles to fix the layout and allow scrolling in small iOS devices in order to solve 2 problems:

  • top selectors are not totally visible
  • bottom buttons are not visible (neither reachable because is not possible to scroll down)

Added styles are only supported in Safari, so Android devices shouldn't be affected

@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented May 9, 2022

Any phone with issues to display the BookPage fully, probably also has issues with displaying the order details and trading prompts (buttons might lay outside). Would it be possible to extend this fix (i.e. add vertical scroll on Safari) to what is displayed in the OrderPage? (url.onion/order/<order_id>)

Need to test and merge. Thanks a lot!! :D

@ozoono
Copy link
Contributor Author

ozoono commented May 9, 2022

You are right. Order details page also has the same issues than the order book. Bottom buttons are not visible, and as there is no scroll , it is not possible to click them (i.e: when you want to confirm a payment)
This fix should solve the problem in both pages.

I can check it in the moment the changes are in Testnet

@ozoono
Copy link
Contributor Author

ozoono commented May 9, 2022

Styles updated to allow scrolling in Safari, into the page with the contract box, just like in the order book and order details page.

@Reckless-Satoshi Reckless-Satoshi merged commit 60944ea into RoboSats:main May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants