Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in spanish translation file #131

Merged
merged 1 commit into from
May 9, 2022

Conversation

ozoono
Copy link
Contributor

@ozoono ozoono commented May 8, 2022

Fix some small typos in spanish translation file, and change a few words so they can be better understood

@Reckless-Satoshi
Copy link
Collaborator

Very well spotted. Thank you!

@Reckless-Satoshi Reckless-Satoshi merged commit 3894ca5 into RoboSats:main May 9, 2022
Copy link
Contributor

@ibertario ibertario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I made some mistakes and now it's much better.

@@ -370,7 +370,7 @@
"Are there trade limits?": "¿Hay límites de intercambios?",
"Maximum single trade size is {{maxAmount}} Satoshis to minimize lightning routing failure. There is no limits to the number of trades per day. A robot can only have one order at a time. However, you can use multiple robots simultaneously in different browsers (remember to back up your robot tokens!).": "Para minimizar fallos en el enrutamiento Lightning, el máximo por intercambio es de {{maxAmount}} Sats. No hay límite de intercambios en el tiempo. Aunque un Robot solo puede intervenir en una orden a la vez, puedes usar varios Robots en diferentes navegadores (¡recuerda guardar los tokens de tus Robots!).",
"Is RoboSats private?": "¿RoboSats es privado?",
"RoboSats will never ask you for your name, country or ID. RoboSats does not custody your funds and does not care who you are. RoboSats does not collect or custody any personal data. For best anonymity use Tor Browser and access the .onion hidden service.": "RoboSats no custodia tus fondos y no recolecta o custodia ningún dato personal, pues no le importa quien eres. RoboSats nunca te preguntará por tu nombre, país o número de documento. Para mejorar tu privacidad, usa el Navegador Tor y visita el sitio cebolla.",
"RoboSats will never ask you for your name, country or ID. RoboSats does not custody your funds and does not care who you are. RoboSats does not collect or custody any personal data. For best anonymity use Tor Browser and access the .onion hidden service.": "RoboSats no custodia tus fondos y no recolecta o custodia ningún dato personal, pues no le importa quien eres. RoboSats nunca te preguntará por tu nombre, país o número de documento. Para mejorar tu privacidad, usa el Navegador Tor y accede al enlace .onion.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sitio cebolla is the spanish Tor Project official translation of Onion services / .onion site

Source https://tb-manual.torproject.org/es/onion-services/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right. I just proposed this alternative because not everybody knows what "servicio cebolla" means, while "enlace .onion" seems something easier to understand.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer to use the exact translations and names used by third-party services, I do not like "sitio cebolla" either (little funny), but the option to use another naming would be to propose to Tor Project the change, while here we use what they have chosen as maintainers.
What do you think, @Reckless-Satoshi ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it does not matter which one we pick:)

Sticking to the Tor Project terminology is a plus. But I had never heard "sitio cebolla" before you proposed it.The Tor Project probably does not have any linguistic professional on their team either :D.

Onion is also straight forward to understand in Spanish since URLs finish with ".onion". It seems to be the most used term by the Spanish speakers in the wild.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I vote in this case for sitio .onion! I will contact also to Tor Project and see... Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants