Convert ExchangeSummaryDialog, ProfileDialog and StatsDialog to Typescript #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit migrates the ExchangeSummaryDialog component to the dialogs folder whilst converting it to Typescript
Convert ProfileDialog component to Typescript and co-locate it inside the dialogs folder
fernandoporazzi
changed the title
Migrate StatsDialog component into its own file and convert its contents to Typescript.
fernandoporazzi
changed the title
Reckless-Satoshi
added a commit
that referenced
this pull request
May 22, 2022
|
Tested, added a small fix and merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Convert
ExchangeSummaryDialog,ProfileDialogandStatsDialogto typescript whilst co-locating the components inside theDialogsfolder.Benefits
The BottomBar component should be smaller and easier to reason now.
More
These commits shouldn't include any breaking changes, however it's recommended to properly test before shipping to production.