Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue#194 #198

Merged
merged 4 commits into from
Jul 31, 2022
Merged

Issue#194 #198

merged 4 commits into from
Jul 31, 2022

Conversation

zx9r
Copy link
Contributor

@zx9r zx9r commented Jul 30, 2022

Fixes #194 though not properly tested

Reckless-Satoshi
Reckless-Satoshi reviewed Jul 30, 2022
View reviewed changes
.env-sample Outdated Show resolved Hide resolved
@zx9r
Copy link
Contributor Author

zx9r commented Jul 30, 2022 •
edited

I modified it in my fork/branch but I dont know how to bring it here to this pull request. Should I create another pull request or is it automatically updated ?

PS: I think it has been automatically updated here but not really sure

@Reckless-Satoshi Reckless-Satoshi mentioned this pull request Jul 31, 2022
Closed
Reckless-Satoshi
Reckless-Satoshi reviewed Jul 31, 2022
View reviewed changes
.env-sample Outdated Show resolved Hide resolved
@Reckless-Satoshi Reckless-Satoshi mentioned this pull request Jul 31, 2022
Closed
@Reckless-Satoshi Reckless-Satoshi added the ⚡Eligible for Sats ⚡ This issue or pull request rewards bitcoin label Jul 31, 2022
@Reckless-Satoshi
Copy link
Collaborator

Hey @zx9r,

Ready to merge, nice work!

As described in #194 (comment) we have 2 concurrent PRs for the same rewarded task, we will be merging this fix instead of #200 .

Given that both solutions are valid, let's split reward of #194 60/40 for the two submitted PRs. Please submit an LN invoice (from a proxy wallet or in private) for 72K Sats

@zx9r
Copy link
Contributor Author

zx9r commented Jul 31, 2022

Thank you !
Here is the invoice: lnbc720u1p3wdy33pp5d7293wdvv98efnfyzwz2tu0a43756r6sgcrmglcldfqwva67724qdqu2askcmr9wssx7e3q2dshgmmndp5scqzpgxqyz5vqsp5zdjsthapznt3q08fz3ycegra3cjudc4rnutpwsldgvc44rhknvdq9qyyssqqecrzc9qdxxw6zv2vkgxeftsrz232pk3y9pcxj59cyhrvzruugs948lch396jy4ree3wqs52xx5n73t97pc649wrc5ljt03raj7qy0sq7dj7sv

@Reckless-Satoshi Reckless-Satoshi merged commit 3ae6087 into RoboSats:main Jul 31, 2022
@Reckless-Satoshi
Copy link
Collaborator

40e02d7c4706f023a6279d8b4473633ecc5b0611c9dae1e5c8208abaf701452e

@zx9r zx9r deleted the issue#194 branch July 31, 2022 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Reckless-Satoshi Reckless-Satoshi Reckless-Satoshi left review comments

Assignees
No one assigned
Labels
⚡Eligible for Sats ⚡ This issue or pull request rewards bitcoin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add onchain address validation compatible with Taproot adresses
2 participants
@zx9r @Reckless-Satoshi