Enable Telegram notifications for order takers #244
Conversation
| else: | ||
| text = f"Hey {user.username}, I will send you a message when someone takes your order with ID {str(order.id)}." | ||
| text = f"Hey {user.username}, I will send you notifications about your RoboSats orders." |
There was a problem hiding this comment.
Maybe not for this PR but probably it's worth it to include also i18n on the backend https://github.com/danhper/python-i18n
There was a problem hiding this comment.
Yes, agree. There is no internationalization implemented on the backend yet, but would be very useful for the Telegram messages.
| <DialogTitle id='open-dispute-dialog-title'>{t('Enable TG Notifications')}</DialogTitle> | ||
| <DialogContent> | ||
| <div style={{ textAlign: 'center' }}> | ||
| <QRCode |
There was a problem hiding this comment.
Is it not possible to also include on click a redirection to bot's web page same as below?
There was a problem hiding this comment.
Do you mean open the t.me website also on click on the <QRcode />? Sounds good!
| @@ -1409,7 +1335,7 @@ class TradeBox extends Component { | |||
| enterTouchDelay={0} | |||
| title={ | |||
| <Trans i18nKey='open_dispute'> | |||
| To open a dispute you need to wait{' '} | |||
| To open a dispute you need to wait | |||
There was a problem hiding this comment.
It is a translation, in this case we <Trans /> component instead of t(). We use the <Trans /> here because this translation has a children component <Countdown...>.
When running npm run format a few days ago the {' '} was introduced, I am not sure why. It made the <Countdown> component dissapear from the translations, as they were tagged with <1></1> (marks where to render the <Coundown/> in the translated component) moved to <2></2> and instead render the empty string ' '.
https://github.com/Reckless-Satoshi/robosats/blob/cd8b607891a786c77986ffee45dbd75f51610a01/frontend/static/locales/en.json#L461
There was a problem hiding this comment.
(sorry for mixing this bug fix in this PR... totally unrelated, it was bugging me!)
| @@ -882,7 +880,6 @@ def cancel_order(cls, order, user, state=None): | |||
| # adds a timeout penalty | |||
| cls.cancel_bond(order.taker_bond) | |||
| cls.kick_taker(order) | |||
| # send_message.delay(order.id,'taker_canceled_b4bond') # too spammy | |||
There was a problem hiding this comment.
I'm not a fan of leaving commented code, do you want to just check how it goes?
There was a problem hiding this comment.
Agree,
I had commented out this line long time ago. I was not sure the solution we found was good enough. But now that I revisited this file, I think it's clear the solution worked out and it is time to delete this commented code, forever (actually, this PR also deletes the function this line is calling to) :D
|
Thanks for your time reviewing @KoalaSat ! |
Feature request, allow order takers to enable Telegram Notifications as well. It is a bad privacy trade-off for the functionality it adds, but hey, it keeps getting requested.
In addition, we move the "Enable Telegram" button to the robot profile to improve UX.
/info/if user is logged in.TradeBoxcomponent to theProfileDialog (watch out! A Dialog that opens a Dialog, things can get weird...)