Chatbox fixes #59
Merged
Chatbox fixes #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It is very unlikely these fixes broke any previous feature. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR:
1 - Recommend users to PGP encrypt their sensitive information in the chat box.
2 - Facilitate long strings sharing in chat.
3 - Small fix that prevents sending empty messages.
As discussed in the main telegram group. Users should not trust the chat being encrypted nor it not being logged. Temporarily, the chat helper information now links to a small tutorial on how to setup OpenKeychain and use it for messaging. This one is to be replaced by: A tutorial explicitly made for OpenKeychain+RoboSats (#60 looking for contributors)
Previously the chat was protected for overflow by long strings by inserting a space-bar every 22 characters. This is very inconvenient when copy-pasting encrypted strings, since one has to manually remove the space-bars. The fix now allows for graceful overflow that does not insert new characters in the string.