Extract getCookie function into its own file #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The getCookie function was being implemented a couple of times across the pages. These changes create a single implementation and imports the helper function whenever needed.
|
Hey @fernandoporazzi, Indeed, this was a bad hack early on that survived until now. This is probably also the case for other functions, I can recall pn() also being copy/pasted into the different components. Will give it a check and merge once I have some time. Happy to see a JS developer checking over the frontend components. Thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getCookiefunction was being implemented a couple of times across the pages. The changes in this PR create a single implementation to retrieve a cookie value by name and imports the helper function whenever needed.