Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BTC instead of Sats on Stats For Nerds #98

Merged
merged 2 commits into from
May 1, 2022

Conversation

ibertario
Copy link
Contributor

In the "Stats For Nerds" we have now:

image

With this pretty good amount of daily volume, is better to have both amounts denominated in BTC:

image

This PR tries to solve that. Can't test but only two minor changes.

@Reckless-Satoshi
Copy link
Collaborator

Reckless-Satoshi commented Apr 17, 2022

Awesome!! I have not tested, but it looks like this PR should work!

Are you sure about this upgrade, though? Daily amounts are always going to be much smaller than lifetime amounts. So it makes sense to have BTC for lifetime, yet it also might be nice to have Sats for those days with low trade volumes (for example, a few days ago the trade volume was only 200.000 Sats).

I propose, we pick a unit (either BTC or Sats). And then, implement a clickable action, so when the number is clicked, the UI rotates units and multiplies or divides by 100000000.

@ibertario
Copy link
Contributor Author

ibertario commented Apr 17, 2022

Daily amounts are always going to be much smaller than lifetime amounts. So it makes sense to have BTC for lifetime, yet it also might be nice to have Sats for those days with low trade volumes (for example, a few days ago the trade volume was only 200.000 Sats).

Some options to minimize the divergence...

  • Add 1 week
  • Last 100 or 1000 blocks stats
  • Little graph with 4 points from the start
  • Choice one good % increase (trades, Robots, medium sats trade...)

Talking about stats, amounts with the same denomination looks better, especially when they are very close.

I think that for a Bitcoin amount BTC is easy to look (especially for Nerds).

This is more a marketing choice, but not really relevant, because RoboSats stats will grow exponentially.

I propose, we pick a unit (either BTC or Sats). And then, implement a clickable action, so when the number is clicked, the UI rotates units and multiplies or divides by 100000000.

That's beyond my current dev capabilities, but definitely can be good to show a button to exchange or a tooltip with the other option.

@ibertario
Copy link
Contributor Author

PS: A button present in all UI that exchange between both BTC<>Sats can be (crazy?) valuated for the future.

@ibertario
Copy link
Contributor Author

This can be merged! As we can see 24h volume is increasing...

image

We can add later another metric:

Some options to minimize the divergence...

* Add 1 week

* Last 100 or 1000 blocks stats

* Little graph with 4 points from the start

* Choice one good % increase (trades, Robots, medium sats trade...)

@Reckless-Satoshi
Copy link
Collaborator

Merging as is. I am still looking forward to have some free time for a full revamp of the summarizing stats :)

@Reckless-Satoshi Reckless-Satoshi merged commit b36155f into RoboSats:main May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants